Re: 2.6.17-rc5-mm1 - output of lock validator

Andrew Morton wrote:
On Wed, 31 May 2006 16:28:59 +0200
Arjan van de Ven <arjan@xxxxxxxxxxxxxxx> wrote:

--- linux-2.6.17-rc5-mm1.5.orig/drivers/net/8390.c
+++ linux-2.6.17-rc5-mm1.5/drivers/net/8390.c
@@ -299,7 +299,7 @@ static int ei_start_xmit(struct sk_buff disable_irq_nosync(dev->irq);

- spin_lock(&ei_local->page_lock);
+ spin_lock_irqsave(&ei_local->page_lock, flags);

Again, notabug - we did disable_irq().

but does disable_irq() work in the light of that irqpoll stuff?

maybe the idiom is no longer really valid...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: Tracking a bug in x86-64
    ... On Wednesday 06 July 2005 08:34 am, Arjan van de Ven wrote: ... This is a tough one, and having one place to go to for the ... send the line "unsubscribe linux-kernel" in ... More majordomo info at http://vger.kernel.org/majordomo-info.html ...
    (Linux-Kernel)
  • Re: [PATCH] Give kjournald a IOPRIO_CLASS_RT io priority
    ... Andrew Morton wrote: ... Arjan van de Ven wrote: ... perhaps for varying values of "1". ... To me that implies they're at least somewhat correlated... ...
    (Linux-Kernel)
  • Re: /dev/hdl not showing up because of fix-ide-probe-double-detection patch
    ... On Iau, 2004-08-05 at 06:47, Andrew Morton wrote: ... they both report that they are Model ... send the line "unsubscribe linux-kernel" in ... More majordomo info at http://vger.kernel.org/majordomo-info.html ...
    (Linux-Kernel)
  • Re: So - Whats going on with Reiser 4?
    ... > Arjan van de Ven wrote: ... >>follow-on questions. ... > More majordomo info at http://vger.kernel.org/majordomo-info.html ... > Please read the FAQ at http://www.tux.org/lkml/ ...
    (Linux-Kernel)
  • Re: gettimeofday order of magnitude slower with pmtimer, which is default
    ... On Tuesday 21 March 2006 23:04, Arjan van de Ven wrote: ... call (which is what function pointer calls end up being) are ... basically always mispredicted unless you have a really really fancy ... More majordomo info at http://vger.kernel.org/majordomo-info.html ...
    (Linux-Kernel)