Re: 2.6.17-rc5-mm1 - output of lock validator


* Arjan van de Ven <arjan@xxxxxxxxxxxxx> wrote:

This is a serious bug in misrouted_irq(). disable_irq() is a
software state and must be repsected.

no that is not correct. The api is a mix kinda and broken; it really
DOES mean "shut this irq source off". That your handler won't get
called is an assumption! You do NOT disable your handler this way.
What we really need is a disable_irq_handler() api that does both!

well, the short-term answer is that Herbert's fix is correct and we need
to do it even if it degrades the efficiency of irqfixup/irqpoll.

after this fix is applied, irqfixup/irqpoll should be enhanced to take
advantage of disable_irq_handler().

in any case, correctness comes first - not honoring IRQ_DISABLED can
lead to lockups.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: Poweroff / shell
    ... it was not the Explorer but Winlogon that handled that broadcast and called to ExitWindowAPI. ... if you are running your own application as the shell you can always "fix" the behavior by providing your own handler for the ... Basically if you catch the message by your window or thread proc, you should call a shutting the system ... Some more info and ways how to intercept the power management events you can find in this thread: ...
    (microsoft.public.windowsxp.embedded)
  • Re: Porting a DOS app to Windows
    ... > The application is in C and is using assembly code for ... Its been implemented in assembly via the interrupts ... delaying using a timer interrupt handler ... > routines in Win API. ...
    (comp.lang.asm.x86)
  • Re: [PATCH] list_for_each_rcu must die: networking
    ... API entirely. ... Updated to remove the two now-unused variables as noted by Dave Miller, ... and also to fix my bonehead error detected by Kamalesh Babulal and ...
    (Linux-Kernel)
  • Re: Winforms, Shown Event and SetEnvironmentVariable
    ... Timing done using "QueryThreadCycleTime" API (Vista and up), with Processor clock at fixed rate. ... If you just put a Stopwatch in the Shown event handler, start it before the two calls, and check the Elapsed time after them, what results do you get? ... Not that it's relevant to this question IMHO, but what's the .NET API for the QueryThreadCycleTime call? ...
    (microsoft.public.dotnet.languages.csharp)
  • Re: Windows System Error on a Toshiba Tecra
    ... Insufficient system resources exist to complete the API ... claims to fix computer problems by scanning your system's registry for errors. ... Unless you are very familiar with the Windows registry, ...
    (microsoft.public.windowsxp.general)