Re: [PATCH 4/4] Make Emulex lpfc driver legacy I/O port free

On Wed, Jun 07, 2006 at 10:56:07PM +0900, Kenji Kaneshige wrote:
Christoph Hellwig wrote:
On Wed, Jun 07, 2006 at 10:11:12PM +0900, Kenji Kaneshige wrote:

I mean the right order is

(1) pci_request_regions()
(2) pci_enable_device*()


no, pci_enable_device should be first.



I had the same wrong assumption before. But to prevent two
devices colliding on the same address range, pci_request_regions()
should be called first. Please see the following discussions:

No. That's what the pci_driver matching is for. Without pci_enable_device
pci_request_regions could do the wrong thing when fixups aren't run.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages