Re: [PATCH] use unlikely() for current_kernel_time() loop



Andi,

On Thu, 08 Jun 2006, Andi Kleen wrote:

Originally because it made assembly too unreadable. Later it was discovered
it produces smaller code too.


Thank you for the explanation. But, this brings to mind two other questions:

Does the option not also make assembly less readable on other architectures?

If one is interested in smaller code, why not use -Os?

Also, does -fno-reorder-blocks actually defeat __builtin_expect()?
(GCC documentation doesn't really say that.)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • Re: [RFC][PATCH 3/9] actual generic PAGE_SIZE infrastructure
    ... Several architectures have some form of this, ... arm uses ULfor this and I think this is much more readable than ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ...
    (Linux-Kernel)
  • [PATCH] hugetlb: Fix clear_user_highpage arguments
    ... This allows architectures with virtually indexed caches a few ... That sort of trick falls over in painful ways if the ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ...
    (Linux-Kernel)
  • Re: [patch] epoll use a single inode ...
    ... architectures (which in turn may end up being slow for an address that ... isn't in the TLB, like NULL), but you depend on a very much internal ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ...
    (Linux-Kernel)
  • [patch 02/28] Add cmpxchg64 and cmpxchg64_local to alpha
    ... Make sure that at least cmpxchg64_local is available on all architectures to use ... static inline unsigned long ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ...
    (Linux-Kernel)
  • [patch 05/28] Add cmpxchg64 and cmpxchg64_local to x86_64
    ... Make sure that at least cmpxchg64_local is available on all architectures to use ... Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal ... More majordomo info at http://vger.kernel.org/majordomo-info.html ... Please read the FAQ at http://www.tux.org/lkml/ ...
    (Linux-Kernel)