Re: [NFS] [PATCH] NFS server does not update mtime on setattr request

On Wednesday June 7, staubach@xxxxxxxxxx wrote:

Neil, can we get these changes integrated, please?

Nope.
The discussion has already gone on from here, so I might be covering
old ground, but there seem to be further mentions of still needing the
server patch, so just to be sure it is covered....

My reading of SUS says that
open(O_TRUNC) of an empty file does not update the modify time
truncate() of an empty file does update the modify time

So the server has to be able to support this distinction without being
able to directly know what API call was made on the client.
The patch you suggest makes it impossible to support that distinction.

Possibly the server could make a distinction between when nfsd_setattr
is called directly, and when it is called via nfsd_create{,_v3}. I
would be more open to a patch that makes a distinction there. However
I think that it would be best for the client to be explicit about what
it is doing by setting the right attr flags.

NeilBrown

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: problems with KB951746
    ... Then, if you are CONFIDENT that you are okay there and the speed issue remains, reconfigure SBS and point it to another DNS server that is known to be patched and working. ... Wien the server-side DNS-vulnerability patch is installed, all my SBS2K3 systems are exhibiting the same problem: extremely show internet access when the system is under load, meaning when three or more clients are trying to access the internet at once. ... My indecision stems from the fact that no symptoms show if there is no load, so if I call CSS after hours I can't show them any symptoms, and I don't want to load the patch during a work day because access is so slow that client work slows to a virtual standstill, the remote branches connections to Exchange server stop responding, and local clients can't do any work that involves the internet. ...
    (microsoft.public.windows.server.sbs)
  • Re: 832894 phish fix -- TCP broken
    ... This patch has damaged one of my W2K servers also. ... the "Client Network" and the "MetaFrame COM Server" ... same with port 80 from B to A. ...
    (microsoft.public.win2000.security)
  • Re: Windows 98SE unexpectedly logs off Windows 2003 standard server
    ... >I don't know your exact problem, but the updated DS client should be worth a try. ... >> letters are mapped to UNS paths on the server. ... When the Novell servers ... >> a patch to apply to the Novell server. ...
    (microsoft.public.win2000.security)
  • Re: [PATCH COW] sys_copyfile
    ... > In some network protocols the client does not know whether the server ... Don't patch bad code, rewrite it. ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)
  • Re: PPTP misery
    ... believe)...*but* it only effects clients with certain patch levels. ... If you prefer to work on the server side without confirming that this ... I suspect that it is an issue with the TCP/IP configuration on the ... Now on to the client side. ...
    (microsoft.public.windows.server.sbs)