Re: 2.6.16-rc6-mm2

Ingo Molnar <mingo@xxxxxxx> writes:

* Ingo Molnar <mingo@xxxxxxx> wrote:


* Christoph Lameter <clameter@xxxxxxx> wrote:

Sorry that patch was still against mm1. Here is a fixed up version
that applies cleanly against mm2:

i have applied both patches you sent in this thread but it still
triggers tons of messages:

trying to fix it i realized that i'd have to touch tons of
architectures, which all duplicate this piece of code:

below is an updated patch that includes fixups for i386 - but the real
fix should be to properly reduce the per-arch local.h footprint to the
bare minimum possible, and to do this fix on the asm-generic headers.

I think an even better approach would be to use local_save_flags() /
local_restore_flags () and then use a normal increment and get
rid of smp_processor_id completely.

I've never seen any evidence that the complex and bloated code generated by
this is any better that just enabling/disabling interrupts.

In the x86 world P4 has costly cli/sti, but I wouldn't expect
that problem to be very widespread.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: 2.6.16-rc6-mm2
    ... architectures, which all duplicate this piece of code: ... and to do this fix on the asm-generic headers. ... I've never seen any evidence that the complex and bloated code generated by ...
    (Linux-Kernel)
  • RE: [PATCH] perf_counter/powerpc: Fix compilation after perf_counter_overflow change
    ... your patches touch definitions used by other architectures. ... architectures' callsites for the things you're changing, ... The below patch should fix it, but I have no means to test it. ... VAT Registration No.: DE129385895 ...
    (Linux-Kernel)
  • Re: [PATCH] perf_event, powerpc: Fix compilation after big perf_counter rename
    ... You really aren't build testing other architectures than x86 right? ... Because not only do i test every architecture i also try to fix upstream ... bugs on non-x86 pro-actively. ...
    (Linux-Kernel)
  • local_softirq_pending()
    ... This is the sort of thing which should be consistent across architectures. ... The obvious and moderately clean fix is: ... +static inline void set_softirq_pending ...
    (Linux-Kernel)
  • Re: [PATCH v2] pm: Move nvs routines into a seperate file.
    ... I'll carry out some compilation testing on it and put it into the tree shortly. ... Subject: [PATCH] PM: add empty suspend/resume device irq functions ... Other architectures will see this build error: ... To fix this add some empty inline functions for!GENERIC_HARDIRQS. ...
    (Linux-Kernel)