Re: 2.6.16-rc6-mm2

Andi Kleen (on 12 Jun 2006 14:14:09 +0200) wrote:
Ingo Molnar <mingo@xxxxxxx> writes:

* Ingo Molnar <mingo@xxxxxxx> wrote:


* Christoph Lameter <clameter@xxxxxxx> wrote:

Sorry that patch was still against mm1. Here is a fixed up version
that applies cleanly against mm2:

i have applied both patches you sent in this thread but it still
triggers tons of messages:

trying to fix it i realized that i'd have to touch tons of
architectures, which all duplicate this piece of code:

below is an updated patch that includes fixups for i386 - but the real
fix should be to properly reduce the per-arch local.h footprint to the
bare minimum possible, and to do this fix on the asm-generic headers.

I think an even better approach would be to use local_save_flags() /
local_restore_flags () and then use a normal increment and get
rid of smp_processor_id completely.

I've never seen any evidence that the complex and bloated code generated by
this is any better that just enabling/disabling interrupts.

In the x86 world P4 has costly cli/sti, but I wouldn't expect
that problem to be very widespread.

I have previously suggested a lightweight solution that pins a process
to a cpu for the short duration that it accesses cpu local variables.
http://lkml.org/lkml/2005/12/16/2. Time to revistit that option?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: 2.6.16-rc6-mm2
    ... triggers tons of messages: ... architectures, which all duplicate this piece of code: ... and to do this fix on the asm-generic headers. ... I've never seen any evidence that the complex and bloated code generated by ...
    (Linux-Kernel)
  • Re: kernel segv with 2.6.31-rc6 ?
    ... Your fix makes module loading work again, ... duplicate section names in these features. ... could just be a single file that contains lines of: ... More majordomo info at http://vger.kernel.org/majordomo-info.html ...
    (Linux-Kernel)
  • Re: How to refresh Debian to install software set
    ... Fix one machine to function correctly, then duplicate the selections using the method described by "s. ... Fix one machine to function correctly, then use the df/netcat method to duplicate the hard disk partition. ... To UNSUBSCRIBE, email to debian-user-REQUEST@xxxxxxxxxxxxxxxx with a subject of "unsubscribe". ...
    (Debian-User)
  • RE: [PATCH] perf_counter/powerpc: Fix compilation after perf_counter_overflow change
    ... your patches touch definitions used by other architectures. ... architectures' callsites for the things you're changing, ... The below patch should fix it, but I have no means to test it. ... VAT Registration No.: DE129385895 ...
    (Linux-Kernel)
  • Re: A very Challenging Question?
    ... Distinct gets rid of all duplicate values, but once again we still have the ... (Named GPSData) ... there TXDates and TXTimes are the same. ... is isolated from all others as the only one with it's own fixdate and fix ...
    (microsoft.public.access.queries)