Re: [patch -mm 20/20 RFC] chardev: GPIO for SCx200 & PC-8736x: add sysfs-GPIO interface
- From: Andrew Morton <akpm@xxxxxxxx>
- Date: Tue, 20 Jun 2006 17:12:04 -0700
Jim Cromie <jim.cromie@xxxxxxxxx> wrote:
Heres a better version
Well..
***************
*** 312,317 ****
}
pc8736x_init_shadow();
return 0;
}
--- 422,428 ----
}
pc8736x_init_shadow();
+ pc8736x_sysfs_init(&pdev->dev);
return 0;
}
I don't know how to fix that - pc8736x_gpio_init() doesn't call
pc8736x_init_shadow().
Plus the patch you sent still has spaces all over the place where we should
have tabs. You can fix that by editing the diff, search for "^+ ".
So I'll drop this patch altogether. Which is probably for the best at this
stage, because we're expecting a pile of teeny fixes from you agaisnt the
other 19 patches as a result of review comments (yes?)
Once all that has landed we can look at the sysfs-GPIO interface.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- References:
- [patch -mm 20/20 RFC] chardev: GPIO for SCx200 & PC-8736x: add sysfs-GPIO interface
- From: Jim Cromie
- Re: [patch -mm 20/20 RFC] chardev: GPIO for SCx200 & PC-8736x: add sysfs-GPIO interface
- From: Andrew Morton
- Re: [patch -mm 20/20 RFC] chardev: GPIO for SCx200 & PC-8736x: add sysfs-GPIO interface
- From: Jim Cromie
- [patch -mm 20/20 RFC] chardev: GPIO for SCx200 & PC-8736x: add sysfs-GPIO interface
- Prev by Date: Re: [linux-usb-devel] USB/hal: USB open() broken? (USB CD burner underruns, USB HDD hard resets)
- Next by Date: Re: [PATCH] Change ll_rw_block() calls in JBD
- Previous by thread: Re: [patch -mm 20/20 RFC] chardev: GPIO for SCx200 & PC-8736x: add sysfs-GPIO interface
- Next by thread: Re: [patch -mm 20/20 RFC] chardev: GPIO for SCx200 & PC-8736x: add sysfs-GPIO interface
- Index(es):
Relevant Pages
|
|
