[-mm patch] gpio: make two mutexes static again



On Wed, Jun 21, 2006 at 03:48:57AM -0700, Andrew Morton wrote:
...
Changes since 2.6.17-rc6-mm2:
...
+chardev-gpio-for-scx200-pc-8736x-replace-spinlocks.patch
...
GPIO driver framework.
...

scx200_gpio_config_lock and pc8736x_gpio_config_lock became global
without a good reason.

Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>

---

arch/i386/kernel/scx200.c | 2 +-
drivers/char/pc8736x_gpio.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

--- linux-2.6.17-mm1-full/arch/i386/kernel/scx200.c.old 2006-06-21 22:32:23.000000000 +0200
+++ linux-2.6.17-mm1-full/arch/i386/kernel/scx200.c 2006-06-21 22:32:32.000000000 +0200
@@ -46,7 +46,7 @@
.probe = scx200_probe,
};

-DEFINE_MUTEX(scx200_gpio_config_lock);
+static DEFINE_MUTEX(scx200_gpio_config_lock);

static void __devinit scx200_init_shadow(void)
{
--- linux-2.6.17-mm1-full/drivers/char/pc8736x_gpio.c.old 2006-06-21 22:46:56.000000000 +0200
+++ linux-2.6.17-mm1-full/drivers/char/pc8736x_gpio.c 2006-06-21 22:47:05.000000000 +0200
@@ -32,7 +32,7 @@
module_param(major, int, 0);
MODULE_PARM_DESC(major, "Major device number");

-DEFINE_MUTEX(pc8736x_gpio_config_lock);
+static DEFINE_MUTEX(pc8736x_gpio_config_lock);
static unsigned pc8736x_gpio_base;
static u8 pc8736x_gpio_shadow[4];


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • Re: [PATCH] bt8xx: unaligned access
    ... The casts aren't strictly necessary here. ... Any reason to keep it? ... on int * et.al. ... Please read the FAQ at http://www.tux.org/lkml/ ...
    (Linux-Kernel)
  • Re: [PATCH] bt8xx: unaligned access
    ... The casts aren't strictly necessary here. ... Any reason to keep it? ... on int * et.al. ... Please read the FAQ at http://www.tux.org/lkml/ ...
    (Linux-Kernel)
  • Re: const_cast, reinterpret_cast
    ... > iterator find (int x) const ... >Is there a particular reason this isn't the case? ... Since you could then modify a const container. ... C++ FAQ: http://www.parashift.com/c++-faq-lite/ ...
    (comp.lang.cpp)
  • Re: K&R2 1.6 Arrays, exercise 1-13 (vertical histogram)
    ... | int main ... I thought you always initialised variables on declaration, ... This, of course, could have been done by initialising on declaration ... (If the latter reason is true, learning it would have done no good here, because Reason 1 would still have applied.) ...
    (comp.lang.c)
  • Re: newbie (dropping numbers) new post
    ... Either use a #define or a constant int here. ... Please note that the above loop is only an example. ... entry error was detected on stdin. ... Reason number 2 for the array idea for scores. ...
    (alt.comp.lang.learn.c-cpp)