[-mm patch] fs/cifs/cifsproto.h: remove #ifdef around small_smb_init_no_tc() prototype



On Sat, Jun 24, 2006 at 06:19:14AM -0700, Andrew Morton wrote:
...
Changes since 2.6.17-mm1:
...
+cifs-build-fix.patch

Fix git-cifs.patch.
...

Let's hope gcc guesses the prototye of the function right.

Otherwise, this patch has turned a compile error into a nasty runtime
error (in many cases, the stack is garbage).

The -Werror-implicit-function-declaration gcc flag would turn such
possible problems into compile errors.

This patch removes the (never required) #ifdef from the prototype of
thie function in fs/cifs/cifsproto.h.

Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>

--- linux-2.6.17-mm2-full/fs/cifs/cifsproto.h.old 2006-06-26 00:00:56.000000000 +0200
+++ linux-2.6.17-mm2-full/fs/cifs/cifsproto.h 2006-06-26 00:01:02.000000000 +0200
@@ -64,11 +64,9 @@
extern void header_assemble(struct smb_hdr *, char /* command */ ,
const struct cifsTconInfo *, int /* length of
fixed section (word count) in two byte units */);
-#ifdef CONFIG_CIFS_EXPERIMENTAL
extern int small_smb_init_no_tc(const int smb_cmd, const int wct,
struct cifsSesInfo *ses,
void ** request_buf);
-#endif
extern int CIFS_SessSetup(unsigned int xid, struct cifsSesInfo *ses,
const int stage,
const struct nls_table *nls_cp);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • Re: [PATCH] iwlwifi 3945: Fix IWL_SCAN compile error
    ... Subject: [PATCH] iwlwifi 3945: Fix IWL_DEBUG_SCAN compile ... compile error when CONFIG_IWLWIFI_DEBUG is enabled. ... I just pulled the latest from Linus but cannot see this problem. ... find that there is one extra commit when comparing the output of 'git ...
    (Linux-Kernel)
  • Re: 2.6.18-rc4-mm2: x86_64 compile error
    ... This patch causes the following compile error (cross compiling from i386 ... Odd - asm/cpufeature.h is being included by asm/processor.h, ... There had been need of rain for many days. ...
    (Linux-Kernel)
  • Re: scsi/arm/fas216.c compile error
    ... It's in mainline 84ac86ca8c6787f9efff28bc04b1b65fe0a5c310 ... to get a responsive maintainer to ACK on them. ... However, if you're seeing a bulid error, it means that the *WRONG* patch ...
    (Linux-Kernel)
  • Re: why does adding 2 bytes together result in an int?
    ... This is because the devleopers of the platform have decided that the return ... compile error: Cannot implicitly convert type 'int' to 'byte'. ... I need to convert ttl into an int? ...
    (microsoft.public.dotnet.languages.csharp)
  • Re: [Announce] [patch] Modular Scheduler Core and Completely Fair Scheduler [CFS]
    ... Compile error here. ... updated the full patch at the cfs-scheduler URL) ... fix the!CONFIG_SMP build error reported by Gabriel C ... +static inline unsigned long long rq_clock ...
    (Linux-Kernel)

Loading