[PATCH] DVB Needs I2C Core



DVB seems to be using i2c ( i2c_transfer() mainly ) all over the place but it is possible to build DVB without having I2C selected. This results in undefined symbol i2c_transfer in DVB module.

This patch makes I2C Core selected automatically if DVB is selected.
Is it the right thing to do?

Thanks
Parag--- linux-2.6.17/drivers/media/dvb/Kconfig.orig 2006-06-30 00:15:13.000000000 -0400
+++ linux-2.6.17/drivers/media/dvb/Kconfig 2006-06-30 00:10:15.000000000 -0400
@@ -7,6 +7,7 @@ menu "Digital Video Broadcasting Devices
config DVB
bool "DVB For Linux"
depends on NET && INET
+ select I2C
---help---
Support Digital Video Broadcasting hardware. Enable this if you
own a DVB adapter and want to use it or if you compile Linux for


Relevant Pages

  • Re: [v4l-dvb-maintainer] [PATCH] DVB Needs I2C Core
    ... undefined symbol i2c_transfer in DVB module. ... own a DVB adapter and want to use it or if you compile Linux for ...
    (Linux-Kernel)
  • Re: 2.6.8-rc3-mm2
    ... It would be nice if this patch would go into 2.6.8. ... And, although the current DVB stuff compiles fine, for correctness ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)
  • Re: 2.6.13-rc2-mm1
    ... This (v4l-lgdt3302-read-status-fix.patch) is actually a dvb patch. ... pretty much useless without the following patches: ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)
  • Re: [PATCH] b2c2: make front-ends selectable and include noob option
    ... > You are going to run into some problems with this patch... ... > only compiles the frontend drivers as modules... ... > support will be built into the flexcop driver, but the module will not yet ... But it simply didn't seem like dvb guys are ...
    (Linux-Kernel)
  • 2.6.19-rc4: known regressions with patches (v2)
    ... Both of the patches below were already available when 2.6.19-rc4 was ... The DVB patch was was sent as part of a DVB update Linus didn't pull for ... The s390 patch seems to await being forwarded by the s390 maintainers. ... patch to revert the commit available ...
    (Linux-Kernel)