[patch] pi-futex: fix mm_struct memory leak
- From: Ingo Molnar <mingo@xxxxxxx>
- Date: Fri, 30 Jun 2006 20:46:21 +0200
From: Vernon Mauery <vernux@xxxxxxxxxx>
Subject: pi-futex: fix mm_struct memory leak
lock_queue was getting called essentially twice in a row and was
continually incrementing the mm_count ref count, thus causing a
memory leak.
Dinakar Guniguntala provided a proper fix for the problem that simply
grabs the spinlock for the hash bucket queue rather than calling
lock_queue.
The second time we do a queue_lock in futex_lock_pi, we really only need
to take the hash bucket lock.
Signed-off-by: Dinakar Guniguntala <dino@xxxxxxxxxx>
Signed-off-by: Vernon Mauery <vernux@xxxxxxxxxx>
Acked-by: Paul E. McKenney <paulmck@xxxxxxxxxx>
Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
---
kernel/futex.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux/kernel/futex.c
===================================================================
--- linux.orig/kernel/futex.c
+++ linux/kernel/futex.c
@@ -1208,7 +1208,7 @@ static int do_futex_lock_pi(u32 __user *
}
down_read(&curr->mm->mmap_sem);
- hb = queue_lock(&q, -1, NULL);
+ spin_lock(q.lock_ptr);
/*
* Got the lock. We might not be the anticipated owner if we
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Prev by Date: Re: [PATCH 10/17] 2.6.17.1 perfmon2 patch for review: PMU context switch
- Next by Date: Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats
- Previous by thread: SATA in 2.6.17 vs 2.6.15 (x86/ICH6)
- Next by thread: [PATCH] IRQ: warning message cleanup
- Index(es):
Relevant Pages
|
