Re: [Ubuntu PATCH] CDROMEJECT cannot eject some devices
- From: James Bottomley <James.Bottomley@xxxxxxxxxxxx>
- Date: Mon, 03 Jul 2006 16:10:31 -0500
On Mon, 2006-07-03 at 13:46 -0700, Randy Dunlap wrote:
- err = blk_send_start_stop(q, bd_disk, 0x02);
+ err = 0;
+
+ err |= blk_send_allow_medium_removal(q, bd_disk);
This piece is clearly wrong. If the medium has physically been locked
(and the lock is managed by the cdrom layer) then we don't want to be
overriding it. It should be up to the user or the tools to figure out
who has it open or mounted and take the appropriate action.
+ err |= blk_send_start_stop(q, bd_disk, 0x01);
And this looks unnecessary. Why does the device need to be started to
eject its medium?
+ err |= blk_send_start_stop(q, bd_disk, 0x02);
James
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- References:
- [Ubuntu PATCH] CDROMEJECT cannot eject some devices
- From: Randy Dunlap
- [Ubuntu PATCH] CDROMEJECT cannot eject some devices
- Prev by Date: Re: ext4 features
- Next by Date: Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats
- Previous by thread: Re: [Ubuntu PATCH] CDROMEJECT cannot eject some devices
- Next by thread: [Ubuntu PATCH] fix VFS nr_files accounting
- Index(es):
Relevant Pages
|
