Re: [-mm patch] drivers/net/e1000/: possible cleanups

On Thu, Jul 06, 2006 at 01:47:33PM -0700, Auke Kok wrote:
Adrian Bunk wrote:
On Mon, Jul 03, 2006 at 03:03:55AM -0700, Andrew Morton wrote:
...
Changes since 2.6.17-mm5:
...
git-e1000.patch
...
git trees.
...

This patch contains the following possible cleanups:
- make needlessly global functions static

I'm fine with those

- #if 0 the following unused global functions:
- e1000_hw.c: e1000_mc_addr_list_update()
- e1000_hw.c: e1000_read_reg_io()
- e1000_hw.c: e1000_enable_pciex_master()
- e1000_hw.c: e1000_ife_disable_dynamic_power_down()
- e1000_hw.c: e1000_ife_enable_dynamic_power_down()
- e1000_hw.c: e1000_write_ich8_word()
- e1000_hw.c: e1000_duplex_reversal()
- e1000_main.c: e1000_io_read()

I'm wondering if we should not remove those alltogether, or are we
preferring to keep the #if 0'd now?

#if 0 is the compromise between not bloating the kernel binary with
unused code and not immediately removing the currently unused code.

If you as a maintainer of this driver say you want a patch to remove
these unused functions I can also send this patch.

Cheers,

Auke
...

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [-mm patch] mm/memcontrol.c: clenups
    ... This patch makes the following needlessly global functions static: ... There had been need of rain for many days. ...
    (Linux-Kernel)
  • Re: [RFC: 2.6 patch] net/netlink/: possible cleanups
    ... make the following needlessly global functions static: ... Can you give a more detailed answer which parts of my patch you disagree ... There had been need of rain for many days. ...
    (Linux-Kernel)
  • Re: wild buckwheat
    ... large patch of raspberries which are grown organically, ... all of the rain, but are looking forward to the Sep-Oct. ...
    (rec.gardens)
  • Re: [2.6 patch] drivers/net/loopback.c: convert to module_init()
    ... but we should verify it before applying such a patch. ... built objects, which loopback always is, the Makefile ordering does ... There had been need of rain for many days. ...
    (Linux-Kernel)
  • Re: 2.6.11-rc2-mm1
    ... > It breaks compilation with gcc-4.0 ... This patch is correct, too. ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)