Re: [PATCH 2/2] Initial generic hypertransport interrupt support.

On Thu, 13 Jul 2006, Eric W. Biederman wrote:
| And I tested it on one of them. The problem is that there is no API in
| the kernel for properly handling hypertransport interrupts or even faking
| it well currently. There is no shame in breaking a bad unmaintainable
| hack, as I did. The responsible thing is to when you find one to
| fix up the code so that things work by design in a maintainable way,
| which I am attempting to do.

There's no problem providing a better replacement, just make sure
that the existing drivers can use it.

| All existing drivers that use HT interrupts are broken by design.

That's a statement designed to provoke arguments, and I'll just leave
it that we disagree.

| Sure. In that case can I please have a good description of what
| weird hacks your hardware designers have done.

There's really nothing special at all about the interrupt
setup, except in one very minor way. The value of the HT interrupt
destination address needs to be copied from HT config space, to
an internal chip register (which is, can, and should be, handled by
the driver init code).

| As I understand
| it I cannot write to the standard registers HT capability registers
| and have things work correctly.

There is nothing unusual or special about that part at all. The only
unusual item is that mentioned in the paragraph above.

| The functions I exported I intend to export. The complaint seems to
| be that you don't have anything that will work on earlier kernels.
| I have to agree you don't.

Huh? I didn't say anything that could possibly be read as applying
to earlier kernels, and to be crystal clear, that's not my concern
at all.

Maybe somebody else can articulate what I'm trying to say, but I don't
think I can say it in a clearer way.

Dave Olson
dave.olson@xxxxxxxxxx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: 2.6.27-rc6 xen soft lockup
    ... device interrupts are bound to vcpu 0 and there's nothing much else to ... During the time of the lockup the cpu load, as measured with cacti, was about 4% ... So I would say mostly idle ... # Device Drivers ...
    (Linux-Kernel)
  • Re: [RFC][PATCH 2/2] PM: Rework handling of interrupts during suspend-resume
    ... not generate an irq. ... Subject: PM: Rework handling of interrupts during suspend-resume ... Introduce two helper functions allowing us to prevent device drivers ... suspend and resume. ...
    (Linux-Kernel)
  • [PATCH 6/11] 2.6.17-rc5 perfmon2 patch for review: new i386 files
    ... * context is locked and interrupts are masked. ... PMU interrupt is masked. ... PMC and PMD registers are live in PMU. ...
    (Linux-Kernel)
  • Re: [PATCH] Documentation: Make fujitsu/frv/kernel-ABI.txt 80 columns wide
    ... -The internal FRV kernel ABI is not quite the same as the userspace ABI. ... -most of them do not have any scratch registers, thus requiring at least one general purpose ... +single-stepping will blithely go on stepping into things like interrupts. ... -to read and once to write), we don't actually disable interrupts at all if we don't have to. ...
    (Linux-Kernel)
  • Re: Strange "Style guide" requirements...
    ... which some of the registers have asynch resets and some ... sets of registers (though we have discussed alternatives ... other reason to exclude resets for an FPGA design process. ... An entity/process hides variables just as well as a process does. ...
    (comp.arch.fpga)