Re: [PATCH] remove volatile from nmi.c
- From: Andrew Morton <akpm@xxxxxxxx>
- Date: Fri, 14 Jul 2006 10:58:41 -0700
On Fri, 14 Jul 2006 10:41:58 -0700 (PDT)
Linus Torvalds <torvalds@xxxxxxxx> wrote:
On Fri, 14 Jul 2006, Steven Rostedt wrote:
endflag = 1;
smp_wmb();
This was what I originally wrote, and then I saw the set_wmb which made
me think that it was the proper way to do things (why else is it
there?). So if it shouldn't be used, then we should get rid of it or at
least mark it deprecated, otherwise you have people like me thinking
that we should use it.
Yeah, we should probably get rid of it. No need to even mark it
deprecated, since nobody uses it anyway.
At a minimum, I think we should not document it in the locking
documentation, making people incorrectly think it might be a good idea.
Hmm? Andrew?
It has no callers and can be trivially reimplemented by any out-of-tree
caller, so we should be able to remove it immediately.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- [PATCH 00/02] remove set_wmb
- From: Steven Rostedt
- [PATCH 01/02] remove set_wmb - doc update
- From: Steven Rostedt
- [PATCH 02/02] remove set_wmb - arch removal
- From: Steven Rostedt
- [PATCH 00/02] remove set_wmb
- References:
- [PATCH] remove volatile from nmi.c
- From: Steven Rostedt
- Re: [PATCH] remove volatile from nmi.c
- From: Linus Torvalds
- Re: [PATCH] remove volatile from nmi.c
- From: Linus Torvalds
- Re: [PATCH] remove volatile from nmi.c
- From: Steven Rostedt
- Re: [PATCH] remove volatile from nmi.c
- From: Linus Torvalds
- [PATCH] remove volatile from nmi.c
- Prev by Date: Re: 2.6.18-rc1-mm2
- Next by Date: Re: 2.6.18-rc1-mm2
- Previous by thread: Re: [PATCH] remove volatile from nmi.c
- Next by thread: [PATCH 02/02] remove set_wmb - arch removal
- Index(es):
Relevant Pages
|
