Re: [patch] slab: always follow arch requested alignments

On Wed, 26 Jul 2006, Pekka J Enberg wrote:

On Wed, 26 Jul 2006, Christoph Lameter wrote:
Well that is a bit far reaching. What is broken is that SLAB_RED_ZONE and
SLAB_STORE_USER ignore any given alignment. If you want to fix that then
you need to modify how both debugging methods work.

Not sure I understand what you mean. Isn't it enough that we disable
debugging if architecture or caller mandated alignment is greater than
BYTES_PER_WORD?

If you disable them then we are fine. I think the main "bug" is that
we create the caches with ARCH_KMALLOC_MINALIGN in kmem_cache_init but
allow debug options on them. It seemss that we need to be able to disable
debugging from kmem_cache_init.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [BLOCK] bh: Ensure bh fits within a page
    ... Crap, that's hard to fix. ... the appropriate slab flags to defeat the redzoning. ... alignment, rather than turning off debugging whenever we want alignment. ...
    (Linux-Kernel)
  • Re: [BLOCK] bh: Ensure bh fits within a page
    ... Crap, that's hard to fix. ... Either that or we should fix redzoning so that it actually preserves ... alignment, rather than turning off debugging whenever we want alignment. ...
    (Linux-Kernel)
  • PROBLEM: x86 alignment check bug
    ... Exception reporting for alignment check violations on x86 is broken ... (unfortunately, rather badly, and rather hard to fix). ... What happens instead is that the last occuring page fault address is ...
    (Linux-Kernel)
  • Re: [PATCH rc8-mm1] hotfix libata-scsi corruption
    ... relax scsi dma alignment, and the patch below is good for a hot-fix. ... that's likely not the entire hot fix ... ... implicating a generic path like this implies that we would get the same ...
    (Linux-Kernel)
  • Re: Java Menu
    ... same as DHTML I didn't know that. ... can't deduce how to get the text to wrap so that it aligns on the right. ... > alignment, case inconsistencies, etc. ... I can fix the lower/upper case ...
    (microsoft.public.frontpage.client)