Re: [PATCH 1/3] add-imacfb-docu-and-detection.patch

Joseph Fannin schrieb:
On Mon, Jul 31, 2006 at 10:25:01AM +0200, Edgar Hucek wrote:
This Patch add basic Machine detection to imacfb and
some Ducumentation bits for imacfb.

+Imacfb does not have any kind of autodetection of your machine.
+You have to add the fillowing kernel parameters in your elilo.conf:
+ Macbook :
+ video=imacfb:macbook
+ MacMini :
+ video=imacfb:mini
+ Macbook Pro 15", iMac 17" :
+ video=imacfb:i17
+ Macbook Pro 17", iMac 20" :
+ video=imacfb:i20

- /* ignore error return of fb_get_options */
- fb_get_options("imacfb", &option);
+ if (!efi_enabled)
+ return -ENODEV;
+ if (!dmi_check_system(dmi_system_table))
+ return -ENODEV;
+ if (model == M_UNKNOWN)
+ return -ENODEV;

So imacfb now defaults to off? That would be good, especially
since it cannot be a module, and doesn't work with the Apple "BIOS"
stuff.

If not, a video=imacfb:off option would be much appreciated.

Yes. Imacfb only works when efi an efi boot is detected and a supported
Apple device is found.

cu

Edgar Hucek

--
Joseph Fannin
jfannin@xxxxxxxxx



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/