Re: [PATCH] x86_64 built-in command line




+#ifdef CONFIG_CMDLINE_BOOL
+ strlcpy(saved_command_line, CONFIG_CMDLINE, COMMAND_LINE_SIZE);
+#endif

I think I would prefer a strcat.

Also you should describe the exact behaviour (override/append) in Kconfig help.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • Re: [PATCH] x86_64 built-in command line
    ... Also you should describe the exact behaviour (override/append) in Kconfig help. ... For generic semantics strcat (or possible prepend) is probably better. ...
    (Linux-Kernel)
  • Re: [PATCH] x86_64 built-in command line
    ... Also you should describe the exact behaviour (override/append) in Kconfig help. ... For generic semantics strcat (or possible prepend) is probably better. ... it doesn't work for numerous kernel options that can't be negated. ...
    (Linux-Kernel)
  • Re: [PATCH] x86_64 built-in command line
    ... Matt Mackall wrote: ... Also you should describe the exact behaviour (override/append) in Kconfig help. ... For generic semantics strcat is probably better. ... I think what I'm hearing is that we need three options: append, prepend or replace. ...
    (Linux-Kernel)
  • Re: [PATCH] x86_64 built-in command line
    ... Matt Mackall wrote: ... Also you should describe the exact behaviour (override/append) in Kconfig help. ... For generic semantics strcat (or possible prepend) is probably better. ...
    (Linux-Kernel)
  • Re: [PATCH] x86_64 built-in command line
    ... Also you should describe the exact behaviour (override/append) in Kconfig help. ... Matt described having a firmware bootloader which passes bogus parameters. ...
    (Linux-Kernel)