Re: [PATCH] x86_64 built-in command line

From: "H. Peter Anvin" <hpa@xxxxxxxxx>
Date: Mon, 31 Jul 2006 13:41:14 -0700

Andi Kleen wrote:

+#ifdef CONFIG_CMDLINE_BOOL
+ strlcpy(saved_command_line, CONFIG_CMDLINE, COMMAND_LINE_SIZE);
+#endif

I think I would prefer a strcat.

Also you should describe the exact behaviour (override/append) in Kconfig help.

In the i386 thread, Matt described having a firmware bootloader which passes bogus parameters. For that case, it would make sense to have a non-default CONFIG option to have override rather than conjoined (and I maintain that the built-in command line should be prepended.)

-hpa

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

References:
- [PATCH] x86_64 built-in command line
  - From: Matt Mackall
- Re: [PATCH] x86_64 built-in command line
  - From: Andi Kleen

Prev by Date: Re: 2.6.17 -> 2.6.18 regression: cpufreq broken since 2.6.18-rc1 on pentium4
Next by Date: Re: [patch 3/3] convert CONFIG tag for a few accounting data used by CSA
Previous by thread: Re: [PATCH] x86_64 built-in command line
Next by thread: [RFC] irqbalance: Mark in-kernel irqbalance as obsolete, set to N by default
Index(es):
- Date
- Thread