Re: [PATCH 9/33] i386 boot: Add serial output support to the decompressor



Andi Kleen <ak@xxxxxxx> writes:


The function pointers in the console structure are also a problem.
static struct console simnow_console = {
.name = "simnow",
.write = simnow_write,
.flags = CON_PRINTBUFFER,
.index = -1,
};

Yes just patch them at runtime.

I guess that can work. It's a bit of a pain though.

Ideally the code would be setup so you can compile out consoles
the user finds uninteresting.

Seems overkill for early_printk

At least compiling completely out probably isn't.
I have had too many times where the size of a bzImage was an important
factor on a project.

It is annoying to have to call strlen on all of the strings
you want to print..

What strlen?

The strlen that is needed to convert putstr(char *s) into the
write method for the early_printk helpers.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • Re: Undefined symbols in 2.6.11-rc5-mm1
    ... So the appended patch throws false positives and thus can ... > kernel, too, independent of the .config, in practice there's no ... > These need to be in lib-y for this mechanism to work. ... so just compiling them into the kernel because one day there may ...
    (Linux-Kernel)
  • Re: Patching... Whats next?
    ... quite clearly, in the patch description of the download page, that you ... should add a '#define ADJSPLIT' line into include/config.h before compiling. ... The executable that was created while compiling the patched source needs to ... by the "make install" step. ...
    (rec.games.roguelike.nethack)
  • Re: How do I get started making a patch?
    ... You'll need a means of compiling C code, ... - You'll need the source code. ... make a patch until you get the game compiling on your system. ... are used for making patches and applying them. ...
    (rec.games.roguelike.nethack)
  • Re: 2.4.28-pre3: broken ips update
    ... > This trivial one line patch corrects my mistake in ips.h. ... > matrix to always check out latest 2.4 development kernel. ... But you absolutely must at least test compiling your driver against the ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)
  • Re: HEADS UP: OpenSSL problems after GCC 4.2 upgrade
    ... On 5/20/07, Alexander Kabaev wrote: ... >> after compiling and linking). ... I guess the previous mentioned patch doesn't fix all cases. ... use unpatched header files from /usr/inlcude/openssl. ...
    (freebsd-current)