[PATCH] sun disk label: fix signed int usage for sector count



The current sun disklabel code uses a signed int for the sector count. When
partitions larger than 1 TB are used, the cast to a sector_t causes the
partition sizes to be invalid:

# cat /proc/paritions | grep sdan
66 112 2146435072 sdan
66 115 9223372036853660736 sdan3
66 120 9223372036853660736 sdan8

This patch switches the sector count to an unsigned int to fix this.

Signed-off-by: Jeff Mahoney <jeffm@xxxxxxxx>

--- linux-2.6.5/fs/partitions/sun.c 2004-04-03 22:38:14.000000000 -0500
+++ linux-2.6.5.fix/fs/partitions/sun.c 2006-08-25 11:54:23.000000000 -0400
@@ -73,7 +73,7 @@
spc = be16_to_cpu(label->ntrks) * be16_to_cpu(label->nsect);
for (i = 0; i < 8; i++, p++) {
unsigned long st_sector;
- int num_sectors;
+ unsigned int num_sectors;

st_sector = be32_to_cpu(p->start_cylinder) * spc;
num_sectors = be32_to_cpu(p->num_sectors);

--
Jeff Mahoney
SUSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • Re: fdisk question (long)
    ... > I have a 120G HDD, in the BIOS is set as LBA. ... > I've used sysinstall to make partitions and the result is bellow: ... BIOS sector numbering starts with sector 1 ... The CHS descriptor has overflowed -- nolonger meaningful. ...
    (freebsd-questions)
  • 4.9 and partitions larger than 1 terabyte
    ... Figures below won't work with BIOS for partitions not in cyl 1 ... BIOS sector numbering starts with sector 1 ... tracks/cylinder: 255 ... cylinders: 13053 ...
    (comp.unix.bsd.freebsd.misc)
  • Re: 200GB IDE disk on old system
    ... the disk so biosroutines can load the kernel? ... Figures below won't work with BIOS for partitions not in cyl 1 ... BIOS sector numbering starts with sector 1 ...
    (comp.unix.bsd.freebsd.misc)
  • Re: Large Drive CBM DOS Mapping Proposals
    ... It should support subdirectories and it will be using the MD/ ... CD/RD commands for this. ... I support as many partitions as the disk can hold, ... 254 on every sector. ...
    (comp.sys.cbm)
  • Re: beating a dead horse - was "Disk defragmentation - is it worth it?"
    ... Yes the imager "debate" is a joke but I think it's good to discuss the ... Testing was with NTFS Partitions. ... Data" options however "Backup Actual Data" results in a sector backup, ...
    (comp.sys.ibm.pc.hardware.storage)