Re: [PATCH 0/4] Change return values from queue_work et al.

Alan Stern wrote:
...
Note that the change falls within the bounds of the documented
behavior, in the sense that any code which was originally written
correctly (i.e., in accordance with the documentation) will continue to
work correctly without generating any warnings.
...

You are right that there is no comment (or better yet, kerneldoc
comment) about what happens if an instance of work_struct is enqueued
twice. However, /a/ there is the source and /b/ Corbet, Rubini,
Kroah-Hartman: LDD3 describes in detail in an easily understood section
how workqueues are to be used. (Workqueues in Linux 2.6.10, that is.)

...
If the
usage is correct then there is no harm in leaving the WARN_ON call where
it is. If the usage is wrong then the call needs to be fixed, and the
maintainer for the subsystem containing the call will soon find out about
it, thanks to the WARN_ON.
...

Acceptable on second thought, particularly in light of your new
replacement functions with improved semantics of their return value.
Although there are cases where the WARN_ON might not go off during a
long time, or where an update won't happen in many months despite
hundreds of reports at dozens of mailing lists and bugzillas.
--
Stefan Richter
-=====-=-==- =--- ===-=
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: ... and more...
    ... Fix m41t00_setand its usage with workqueues ... +static ulong new_time; ...
    (Linux-Kernel)
  • Re: [PATCH][kernel-doc] Add DocBook documentation for workqueue functions
    ... adds a new section "Workqueues and Kevents" and adds documentation for ... Some functions in this file already had DocBook-style comments, ...
    (Linux-Kernel)
  • Re: Running out of memory - but Im sure I have enough
    ... Anyway, my commit charge is around 750MB, PF Usage around 270MB. ... "Gerry Cornell" wrote: ... > Your quote is ambiguous and almost certainly written in 2001. ... > Unfortunately not all Microsoft documentation is 100% accurate. ...
    (microsoft.public.windowsxp.perform_maintain)
  • Re: Documentation
    ... I propose to BAN all extensions included with Tcl distribution that do ... not have detailed documentation plus understandable examples of usage. ... Many of the packages sit there for years and nobody uses them. ...
    (comp.lang.tcl)
  • Re: How to use TagSoup programatically
    ... HTML errors? ... All documentation is found in the net mentioned only command line usage if it ...
    (comp.lang.java.programmer)