Re: bug in nfs in 2.6.18-rc5?

Shaya Potter wrote:
so I'm trying to use unionfs, cachefs and nfs, as cachefs is 2.6.18-rc5 right now, thats what I'm testing, but I hit an oops.

basically unionfs's lookup does a "lookup_one_len()" on the underlying fs.

lookup_one_len() calls __lookup_hash()

__lookup_hash() is called as "__lookup_hash(&this, base, NULL)"

now that NULL is important. that's the nameidata entry of __lookup_hash()

__lookup_hash() ends up calling the underlying fs's lookup op, i.e. nfs_lookup()

nfs_lookup() calls nfs_reval_fsid(nd->mnt, dir, &fhandle, &fattr);

see the bug? :)

This doesn't seem like a unionfs bug, as one should be able to call lookup_one_len() on an NFS fs.

ok my "fix" is basically that nfs_reval_fsid() uses the nd->mnt to get to mnt->mnt_root.

I basically switched it to take a dentry and I call it as

nfs_reval_fsid(dentry->d_sb->s_root, dir.....)

have no clue if this is correct, but it doesn't oops anymore and seems to "work".
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: Oops with tmpfs on both 2.4.22 & 2.6.0-test11
    ... > This is significantly different in nature from the 2.4 oops, ... > 2.4 hit NULL and this pointer is total garbage. ... seekdir is fine ... The best thing to hit the internet in years - Juno SpeedBand! ...
    (Linux-Kernel)
  • Re: qla2xxx related oops in 2.6.16-rc1
    ... > On Fri, 27 Jan 2006, Stefan Kaltenbrunner wrote: ... >> devicemapper based multipath infrastructure. ... >> The oops happend during heavy io on the devicemapper device and a reboot ... I hit it as well several times during my testing of ...
    (Linux-Kernel)
  • Re: [patch] Race condition in usermodehelper.
    ... You really have to hit the machine hard to provoke ... this oops. ...
    (Linux-Kernel)
  • Re: 2.6.1 oops in prune_dcache()
    ... had to hit the reset button to ... > reboot it. ... This is the first oops ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)
  • Re: unmount oops in log_do_checkpoint
    ... and every time rebooting with a patched ... >> kernel fails to result in the oops. ... One would almost expect some odd patch interaction, ... What's strange is that nobody else has hit it... ...
    (Linux-Kernel)