Re: bug in nfs in 2.6.18-rc5?

Trond Myklebust wrote:
On Thu, 2006-08-31 at 10:54 -0400, Shaya Potter wrote:

__lookup_hash() ends up calling the underlying fs's lookup op, i.e. nfs_lookup()

nfs_lookup() calls nfs_reval_fsid(nd->mnt, dir, &fhandle, &fattr);

see the bug? :)

This doesn't seem like a unionfs bug, as one should be able to call lookup_one_len() on an NFS fs.

Did someone start handing out these promises when I wasn't looking?

AFAICS, lookup_one_len() should only be used by the filesystem itself,
or by services like nfsd that have intimate knowledge of the
filesystem's inner workings.

The reason why NFS would like to insist on that nameidata is that we
need to be able to create mountpoints on the fly when we cross from one
filesystem on the server to another. Otherwise, we cannot offer the type
of guarantees that POSIX applications expect, such as the ability to
provide unique permanent inode numbers.
If we're to provide the ability for unionfs to use lookup_one_len() on
NFS, then we will have to error out whenever we hit a case where we
should be creating a new mountpoint. Is that acceptable?

why does the client care about server mounted file systems? The server's nfsd has to tell them apart, otherwise shouldn't give them to the client. Otherwise it seems like the nfsd and the nfs client have to have innate knowledge of each other.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: activate NFS - ugidd 9.1
    ... > What problems are you getting exactly when trying to connect using nfs? ... > see nfsd try modprobe nfsd and connect again. ... I have my home directory on a server in the lan which runs SuSE 9.0 When I ... As long as I ran SuSE 9.0 on the client machines I could access this ...
    (alt.os.linux.suse)
  • Re: High load average mail server 5.3-RELEASE
    ... nfsiod on the client, setting both to 50, ... I think that the nfs performance will be much better :-) ... In my case more memory would help, ... > Also, if it is an NFS server, one should check the cpu times on the nfsd ...
    (freebsd-performance)
  • What machine connected to particular nfsd?
    ... Francisco> I had an nfsd proces which was using up all the I/O the ... Francisco> machine could handle. ... When we say that NFS ... Francisco> that I don't know which client machine. ...
    (freebsd-isp)
  • Re: bug in nfs in 2.6.18-rc5?
    ... This doesn't seem like a unionfs bug, as one should be able to call ... The reason why NFS would like to insist on that nameidata is that we ... need to be able to create mountpoints on the fly when we cross from one ... If we're to provide the ability for unionfs to use lookup_one_lenon ...
    (Linux-Kernel)
  • Re: Help me replace some Windows installations
    ... > Possible with untrusted clients in SMB, and trusted clients in NFS. ... >> trust every client that might be connected to this network. ... > Still, user ABC on client, accesses to server with rights of the user ... > which Peter already told you about, or use SMB for Linux to Linux ...
    (comp.os.linux.setup)