Re: Support for TI FlashMedia (pci id 104c:8033, 104c:803b) flash card readers

Andrew, the stuff meant for you is at the bottom.

Alex Dubov wrote:
Hi there.
I've made a couple of fixes to my flashmedia driver
(http://developer.berlios.de/projects/tifmxx/) to the
effect of much improved R/W speed in PIO mode and
writing speed in DMA mode.


The users will be pleased :)

I also tried to clean-up reverse engineering mess out
of the code - it should be more readable now.


Wonderful. Things are looking a lot better. I have a few questions though.

The constants you've borrowed from OMAP, have you confirmed all of them?
If not, you should add a comment to those that are pure speculation so far.

tifm_sd_op_flags() still use literals. Could you fix up some defines
there as well?

tifm_sd_fetch_resp() could be redone as a for loop to make it more
obvious what's going on. Also, please don't put several statements on
one line.

You should probably rename tifm_sd_set_data_to(). It isn't obvious that
'to' stands for 'timeout'. Same thing with other instances of 'to'.

We're also in the process of fixing this dreadfully slow write mess.
What I'd like to see from you is to double check that bytes_xfered is
set to the number of bytes successfully sent to the _card_, not the
controller. This is critical for correct handling of bus errors.

Next on my list is MemoryStick functionality.



I would suggest finishing this and getting it merged to be your top
priority. There are quite a few people who would like to have this
hardware supported. Which brings me to...

Andrew, we could use some help with how this driver should fit into the
kernel tree. The hardware is multi-function, so there will be a couple
of drivers, one for every function, and a common part. How has this been
organised in the past?

Rgds
Pierre


--
VGER BF report: H 0.0963121
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • RE: Computer not Recognizing that the DVD-RW drive can record
    ... I'll have to check if they offer a driver on their site. ... "Andrew" wrote: ... CD-RW disks. ... make a DVD movie of my own, my computer does not recognize that I have a ...
    (microsoft.public.windowsxp.hardware)
  • Re: Fastest way to run DELETE on a large table
    ... Andrew J. Kelly SQL MVP ... > bug in the MS JDBC Driver, dont know if it is true. ... >> Andrew J. Kelly SQL MVP ... However I received a bunch of exception for people querying ...
    (microsoft.public.sqlserver.programming)
  • Re: NAND Flash drive in CE 6.0
    ... Andrew to my thread. ... To summarize there are basically two ways to do a FAL/FMD driver (that ... The second method is to re-map the blocks in your FMD driver so that ... there are no reserved blocks. ...
    (microsoft.public.windowsce.platbuilder)
  • Re: Support for TI FlashMedia (pci id 104c:8033, 104c:803b) flash card readers
    ... I've made a couple of fixes to my flashmedia driver ... effect of much improved R/W speed in PIO mode and ... we could use some help with how this driver should fit into the ...
    (Linux-Kernel)
  • Re: [PATCH 0/3] ramzswap: Eliminate stale data from compressed memory (v2)
    ... Andrew Morton wrote: ... effectiveness of ramzswap - how much memory it saves. ... proposing here a permanent extension to the kernel ABI which we will ... We need it because the slab allocator is not a good fit for this special purpose driver due to fragmentation. ...
    (Linux-Kernel)