Re: [PATCH] arch/i386/pci/mmconfig.c tlb flush fix



Andi Kleen <ak@xxxxxxx> writes:

On Tuesday 26 September 2006 17:45, OGAWA Hirofumi wrote:
Andi Kleen <ak@xxxxxxx> writes:

OGAWA Hirofumi <hogawa@xxxxxxxxxxxxxxxx> writes:

We use the fixmap for accessing pci config space in pci_mmcfg_read/write().
The problem is in pci_exp_set_dev_base(). It is caching a last
accessed address to avoid calling set_fixmap_nocache() whenever
pci_mmcfg_read/write() is used.


Good catch. I already had another report of mmconfig corruption on i386,
but didn't have time to look at it yet.

Will be definitely stable material once it hit mainline.

Indeed.

If I found this in mainline, should I send something like a reminder
email with patch to you, Greg?

I have it already queued for both.

Oh, thanks.
--
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • [PATCH] arch/i386/pci/mmconfig.c tlb flush fix
    ... We use the fixmap for accessing pci config space in pci_mmcfg_read/write. ... accessed address to avoid calling set_fixmap_nocachewhenever ... OGAWA Hirofumi ...
    (Linux-Kernel)
  • Re: [PATCH] arch/i386/pci/mmconfig.c tlb flush fix
    ... OGAWA Hirofumi writes: ... We use the fixmap for accessing pci config space in pci_mmcfg_read/write. ... accessed address to avoid calling set_fixmap_nocachewhenever ...
    (Linux-Kernel)
  • [PATCH] arch/i386/pci/mmconfig.c tlb flush fix
    ... We use the fixmap for accessing pci config space in pci_mmcfg_read/write. ... accessed address to avoid calling set_fixmap_nocachewhenever ... Please read the FAQ at http://www.tux.org/lkml/ ...
    (Linux-Kernel)
  • Re: [PATCH] arch/i386/pci/mmconfig.c tlb flush fix
    ... We use the fixmap for accessing pci config space in pci_mmcfg_read/write. ... accessed address to avoid calling set_fixmap_nocachewhenever ... Will be definitely stable material once it hit mainline. ...
    (Linux-Kernel)
  • Re: [PATCH] arch/i386/pci/mmconfig.c tlb flush fix
    ... We use the fixmap for accessing pci config space in pci_mmcfg_read/write. ... accessed address to avoid calling set_fixmap_nocachewhenever ... Will be definitely stable material once it hit mainline. ...
    (Linux-Kernel)