Re: [PATCH 6/6]: powerpc/cell spidernet refine locking

On Fri, 29 Sep 2006 18:29:11 -0500
linas@xxxxxxxxxxxxxx (Linas Vepstas) wrote:

The transmit side of the spider ethernet driver currently
places locks around some very large chunks of code. This
results in a fair amount of lock contention is some cases.
This patch makes the locks much more fine-grained, protecting
only the cirtical sections. One lock is used to protect
three locations: the queue head and tail pointers, and the
queue low-watermark location.

You have spider_net_set_low_watermark() walking the tx_chain outside
tx_chain.lock. Are you sure about that?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [RFC] ext3/jbd race: releasing in-use journal_heads
    ... I think the biggest problem here is that there's really no ... > written rule protecting this stuff universally. ... As long as there's some overlap in the locks, ...
    (Linux-Kernel)
  • Re: deadlocks
    ... Most software I've worked on is not multiple identical threads working with the same locks. ... modify A 2.acquire modify B 3.acquire modify C 1.release at this point another thread can modify A <- potential damage 3.release 2.release ... The potential damage is because the A should be protected. ... But 3 and 2 are not protecting A. ...
    (comp.lang.java.programmer)
  • Re: [RFC] ext3/jbd race: releasing in-use journal_heads
    ... I think the biggest problem here is that there's really no ... written rule protecting this stuff universally. ... As long as there's some overlap in the locks, ...
    (Linux-Kernel)
  • Re: deadlocks
    ... >complex than several identical threads using the same locks. ... But 3 and 2 are not protecting A. ... I wouldn't call that a problem with releasing ...
    (comp.lang.java.programmer)
  • Re: [PATCH 6/6]: powerpc/cell spidernet refine locking
    ... This patch makes the locks much more fine-grained, protecting ... queue low-watermark location. ...
    (Linux-Kernel)