Re: 2.6.18-mm2

On Sat, Sep 30, 2006 at 10:26:22AM -0500, James Bottomley wrote:
On Fri, 2006-09-29 at 23:50 +0000, Frederik Deweerdt wrote:
+ if (!pdev->irq)
+ return -ENODEV;
+

Don't I remember that 0 is a valid IRQ on some platforms?

i.e. shouldn't this be

if (pdev->irq == NO_IRQ)
return -ENODEV;

?

I think this won't quite work because only the platforms that actually
have a valid zero irq define it, but there must be something else that
works.

Linus threw a hissy fit and declared that platforms which use 0 as a
valid IRQ are broken and wrong. Despite PCI using 255 to mean no IRQ
and 0 as a valid IRQ ;-)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages