Re: How is Code in do_sys_settimeofday() safe in case of SMP and Nest Kernel Path?
- From: Christoph Lameter <clameter@xxxxxxx>
- Date: Sat, 30 Sep 2006 10:26:06 -0700 (PDT)
On Sun, 1 Oct 2006, Dong Feng wrote:
--- kernel/time.c.orig 2006-09-30 23:21:29.000000000 +0800
+++ kernel/time.c 2006-09-30 23:38:18.000000000 +0800
@@ -107,7 +107,16 @@ asmlinkage long sys_gettimeofday(struct
return -EFAULT;
}
if (unlikely(tz != NULL)) {
- if (copy_to_user(tz, &sys_tz, sizeof(sys_tz)))
+ struct timezone ktz;
+ unsigned long seq;
+
+ do {
+ seq = read_seqbegin(&xtime_lock);
+ ktz.tz_minuteswest = sys_tz.tz_minuteswest;
+ ktz.tz_dsttime = sys_tz.tz_dsttime;
+ } while (unlikely(read_seqretry(&xtime_lock, seq)));
+
+ if (copy_to_user(tz, &ktz, sizeof(ktz)))
return -EFAULT;
I really hate adding overhead to gettimeofday() and we would have to take
the seqlock in all places when we reference tz. Maybe we can tolerate the
resulting race?
If we assume word size transfers then we only have an issue on 32 bit
platforms. The result of the race would be that tz_minuteswest and
tz_dsttime disagree. So we may get daylight savings time wrong.
But then we are already changing the timezone and are potentially warping time.
gettimofday may be unstable anyways. So it may be okay to leave the race
in. Just add some comments explaining the situation.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- References:
- How is Code in do_sys_settimeofday() safe in case of SMP and Nest Kernel Path?
- From: Dong Feng
- Re: How is Code in do_sys_settimeofday() safe in case of SMP and Nest Kernel Path?
- From: Christoph Lameter
- Re: How is Code in do_sys_settimeofday() safe in case of SMP and Nest Kernel Path?
- From: Dong Feng
- Re: How is Code in do_sys_settimeofday() safe in case of SMP and Nest Kernel Path?
- From: Nick Piggin
- Re: How is Code in do_sys_settimeofday() safe in case of SMP and Nest Kernel Path?
- From: Dong Feng
- How is Code in do_sys_settimeofday() safe in case of SMP and Nest Kernel Path?
- Prev by Date: Re: [patch 02/23] GTOD: persistent clock support, core
- Next by Date: RE: Postal 56% waits for flock_lock_file_wait
- Previous by thread: Re: How is Code in do_sys_settimeofday() safe in case of SMP and Nest Kernel Path?
- Next by thread: [PATCH] Don't start kipmid if the IPMI driver can use interrupts
- Index(es):
Relevant Pages
|
