[PATCH] off-by-one in kernel command line option parsing

From: Vincent Legoll <legoll@xxxxxxxxx>
Date: Sat, 30 Sep 2006 20:20:28 +0200

Here is a patch for what I think is a bug in the kernel,
please comment / apply as appropriate.

Generated by cg-mkpatch from a fairly recent git tree.
Cross-compile tested.

--
Vincent Legoll

fix memcmp() off-by-one
nolapic is 7 chars long

---
commit aa2cb4b05c437005ccff44084678948c99aa62b3
tree 54ddca6ab0ef9a29bb1ff0f452b1eaccce7b33a1
parent 4ed4b5475211fab6a0ad00eed2f9297395e7598e
author Vincent Legoll <vincent.legoll@xxxxxxxxx> Sat, 30 Sep 2006 18:52:53 +0200
committer Vincent Legoll <vincent.legoll@xxxxxxxxx> Sat, 30 Sep 2006 18:52:53 +0200

arch/i386/kernel/setup.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/i386/kernel/setup.c b/arch/i386/kernel/setup.c
index f168220..72bbf22 100644
--- a/arch/i386/kernel/setup.c
+++ b/arch/i386/kernel/setup.c
@@ -869,7 +869,7 @@ #ifdef CONFIG_X86_LOCAL_APIC
lapic_enable();

/* disable local APIC */
- else if (!memcmp(from, "nolapic", 6))
+ else if (!memcmp(from, "nolapic", 7))
lapic_disable();
#endif /* CONFIG_X86_LOCAL_APIC */

Follow-Ups:
- Re: [PATCH] off-by-one in kernel command line option parsing
  - From: Andi Kleen

Prev by Date: Performance analysis of Linux Kernel Markers 0.20 for 2.6.17
Next by Date: Re: 2.6.18-mm2 - possible recursive locking detected
Previous by thread: Performance analysis of Linux Kernel Markers 0.20 for 2.6.17
Next by thread: Re: [PATCH] off-by-one in kernel command line option parsing
Index(es):
- Date
- Thread

Relevant Pages

Re: [patch, rfc] mm.h, security.h, key.h and preventing namespace poisoning
... I just updated a git tree and started getting errors on a ... "copy_keys" macro
warning. ... it doesn't end up with kernel wide scope. ... (Linux-Kernel)
Re: 2.6.24-rc3-mm1 - Kernel Panic on IO-APIC
... ACPI or x86 breakage, I guess. ... could someone try to bisect it so
that ... So the bug wasn't in git-x86 in 2.6.24-rc3-mm1. ... The -mm git tree
reimports the plain git-foo.patch files back into a new ... (Linux-Kernel)
Re: 2.6.21-rc5-mm4
... The kernel also panics when I do this: ... EIP is at 0xffffffff ...
I just pulled your e1000 git tree into vanilla 2.6.21-rc5 ytrr and I can't reproduce the problem,
so it might be caused by something else. ... More majordomo info at http://vger.kernel.org/majordomo-info.html
... (Linux-Kernel)
Re: [GIT PATCH] driver core patches against 2.6.24
... Here are a pretty large number of kobject, documentation, and driver ... core
patches against your 2.6.24 git tree. ... default Fedora initrd (which is trying to load
modules for stuff that I ... + my git tree and lots of USB drivers built into the kernel
also ... (Linux-Kernel)
Git tree for old kernels
... interest in making a git tree with all of the kernel versions from the ...
mailing list and newsgroup archives in order to find announcements to ... could help me
find those and send me copies of relevant announcements. ... (Linux-Kernel)