Re: 2.6.18-mm2

Ar Sad, 2006-09-30 am 10:26 -0500, ysgrifennodd James Bottomley:
On Fri, 2006-09-29 at 23:50 +0000, Frederik Deweerdt wrote:
+ if (!pdev->irq)
+ return -ENODEV;
+

Don't I remember that 0 is a valid IRQ on some platforms?

i.e. shouldn't this be

if (pdev->irq == NO_IRQ)
return -ENODEV;

NO_IRQ is gone. Everyone uses zero and Linus has declared that is how it
shall be.


Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: Turn off ZeroDivisionError?
    ... platforms do exactly what I want for division by zero: ... Python doesn't generate exceptions for other floating point ... case of division by zero. ...
    (comp.lang.python)
  • Re: Null pointers
    ... >> zero is a valid location, and you can safely read and write from it. ... However most platforms won't allow this. ... actually several common desk top operating systems that you happen ... you can access memory at address "all bits 0". ...
    (comp.lang.c)
  • Re: DateSerial question
    ... "JMorrell" wrote in message ... How does a zero in the last ... It really is the single-most versatile date function I've ever run across. ... How I wish a few of the other platforms I work with had a similar one. ...
    (microsoft.public.access.queries)
  • Re: pcmcia: patch to fix pccard_store_cis
    ... write count and not zero. ... Thanks -- Linus was faster, though, and already applied his patch to the ... linux-2.6 git tree. ...
    (Linux-Kernel)
  • Re: alignment
    ... union {char a; int i;} u; ... Besides, if it does "work," how can you check that it does the same thing on all the platforms of interest to you? ... On a long-ago platform I learned on, it would zero out ...
    (comp.lang.c)