Re: 2.6.18-mm2 - oops in cache_alloc_refill()

On Tue, Oct 03, 2006 at 06:45:35PM +0200, Samuel Tardieu wrote:
On 3/10, Jean Tourrilhes wrote:

| > I suggest that you revert the memset() to IW_ESSID_MAX_SIZE+1 so that
| > the last byte is cleared as well. Or am I missing something?
|
| No, that would bring back the slab/memory overflow we are
| trying to get rid of.

Then I am puzzled by the function declaration:

static int orinoco_hw_get_essid(struct orinoco_private *priv, int *active,
char buf[IW_ESSID_MAX_SIZE+1])

Do you mean that this function is called with a buf parameter which
doesn't have the expected size? (as far as the function declaration is
concerned) Shouldn't the declaration be changed to

static int orinoco_hw_get_essid(struct orinoco_private *priv, int *active,
char buf[IW_ESSID_MAX_SIZE])

then to reflect the reality? (it won't change the code but would be
clearer from a documentation point of view)

Yep, that one is a bug.
Thanks !

Sam

Jean
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: 2.6.18-mm2 - oops in cache_alloc_refill()
    ... Or am I missing something? ... that would bring back the slab/memory overflow we are ... Then I am puzzled by the function declaration: ... clearer from a documentation point of view) ...
    (Linux-Kernel)
  • Re: Why doesnt this work?
    ... > I am missing something here. ... Is it clearer yet? ... Until real software engineering is developed, the next best practice ... is to develop with a dynamic system that has extreme late binding in ...
    (comp.lang.lisp)
  • Re: help, epsilon - N proof of a limit of a sequence
    ... and seems clearer to me: ... I think I might be missing something very critical in my understanding ... --Tim Smith ...
    (sci.math)
  • Re: stupid error doing my head it! (C programming)
    ... Personally I never use pre-increment - I only use post-increment because ... sometimes it is clearer than adding 1. ... Seems you are missing the wood for the trees anyway, ...
    (comp.programming)