Re: [patch 4/5] mm: add vm_insert_pfn helpler
- From: Nick Piggin <nickpiggin@xxxxxxxxxxxx>
- Date: Tue, 10 Oct 2006 10:42:51 +1000
Benjamin Herrenschmidt wrote:
+ vma->vm_flags |= VM_PFNMAP;
I wouldn't do that here. I would keep that to the caller (and set it
before setting the PTE along with a wmb maybe to make sure it's visible
before the PTE no ?)
Oops, good catch. You're right.
We probably don't need a barrier because we take the ptl lock
around setting the pte, and the only other readers who care should
be ones that also take the same ptl lock.
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com -
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- ptrace and pfn mappings
- From: Benjamin Herrenschmidt
- faults and signals
- From: Benjamin Herrenschmidt
- ptrace and pfn mappings
- References:
- [rfc] 2.6.19-rc1-git5: consolidation of file backed fault handlers
- From: Nick Piggin
- [patch 4/5] mm: add vm_insert_pfn helpler
- From: Nick Piggin
- Re: [patch 4/5] mm: add vm_insert_pfn helpler
- From: Benjamin Herrenschmidt
- [rfc] 2.6.19-rc1-git5: consolidation of file backed fault handlers
- Prev by Date: cumshhots on glorious Girlss.
- Next by Date: Re: [rfc] 2.6.19-rc1-git5: consolidation of file backed fault handlers
- Previous by thread: Re: [patch 4/5] mm: add vm_insert_pfn helpler
- Next by thread: faults and signals
- Index(es):
Relevant Pages
|
|
