Re: [PATCH] Generic platform device IDE driver

On Fri, Oct 13, 2006 at 08:52:19AM +0100, Russell King wrote:
On Thu, Oct 12, 2006 at 03:13:48PM +0900, Paul Mundt wrote:
Yes, that's one thing I was thinking of as well.. Here's a patch that
makes an attempt at that, can you give it a try and see if it works for
you? This applies on top of the earlier patch. None of the ARM, SH, or
H8300 cases need to do the remapping at least.

It's likely that ARM will switch over to using the MMIO resources if
this patch makes it in. There's certain ARM platforms which would
benefit from this change (since inb() and friends are more complex
than they necessarily need to be.)

However, one issue needs to be solved before we could do that - how do
we handle the case where the IDE registers are on a 4 byte spacing
interval instead of the usual 1 byte?

We could solve this in the driver, but it sounds like this is something
that libata should have some visibility of directly.

I notice that this driver is calling ata_std_ports() which handles
the standard setup. Maybe that needs to become a little more inteligent?

If we go this route, I suppose the easiest option will be simply to have
a private structure with a few function pointers for these sorts of
things, or we can simply have an element for the spacing interval if you
don't forsee needing to change the ioaddrs in any fashion beyond the
register spacing.. Which approach would you be more comfortable with?
Are there any other items that you're concerned with in the current
driver?

Thanks for the feedback!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [patch 2.6.20-rc3 1/3] rtc-cmos driver
    ... To build your new patch for ARM I have modified the line "depends on ... configured that driver as a module. ... As for the RTC patch, it does work on the shark, and is needed. ...
    (Linux-Kernel)
  • Re: Fwd: Re: [2.6.24 patch] restore ARMv6 OProfile support
    ... generic kernel/Kconfig.instrumentation file into the arm directory, ... So it allows the sharing of the common case and *many* architectures end ... it goes along the lines of the patch I suggested as a reply to ... It puts the config options in arch/arm/Kconfig. ...
    (Linux-Kernel)
  • Re: CT SCAN ETC...UPDATE (LONG)
    ... I've maxed out on my lifetime quota of iodine. ... They stopped everything and did another IV in the other arm. ... resulted in no RA related lung problems, no COPD or other lung problems. ... I posted earlier about my adverse reaction to the Fentanyl patch. ...
    (alt.support.arthritis)
  • CT SCAN ETC...UPDATE (LONG)
    ... They stopped everything and did another IV in the other arm. ... If redness or increased swelling appears ... resulted in no RA related lung problems, no COPD or other lung problems. ... I posted earlier about my adverse reaction to the Fentanyl patch. ...
    (alt.support.arthritis)
  • Re: [PATCH] Generic platform device IDE driver
    ... It's likely that ARM will switch over to using the MMIO resources if ... or we can simply have an element for the spacing interval if you ... Here's the decision matrix for libata: Will the hardware use the standard taskfile push/pull functions like ata_tf_load, ata_tf_read, ata_exec_command, etc.? ... If the hardware requires non-standard I/O accessors, or the register sizes themselves changed, then you must implement your own taskfile I/O ...
    (Linux-Kernel)