Re: [linux-pm] Bug in PCI core
- From: Adam Belay <abelay@xxxxxxx>
- Date: Fri, 13 Oct 2006 12:40:31 -0400
On Fri, 2006-10-13 at 17:29 +0200, Arjan van de Ven wrote:
On Fri, 2006-10-13 at 16:26 +0100, Alan Cox wrote:
Ar Gwe, 2006-10-13 am 10:29 -0400, ysgrifennodd Alan Stern:
I'd like to propose that we have the pci config sysfs interface return
-EIO when it's blocked (e.g. active BIST or D3cold). This accurately
reflects the state of the device to userspace, reduces complexity, and
could potentially save some memory per PCI device instance.
Could you resubmit your old patches and include a corresponding fix for
this access problem?
And then you can fix the applications it breaks, like the X server which
does actually want to know where all the devices are located in PCI
space.
.. but which could equally well mmap the resource from sysfs ;)
also the thing this patch does is ONLY when the device is effectively
off the bus return -EIO.
One can argue that -EAGAIN is nicer since it's only a temporary
condition though....
Yeah, perhaps -EAGAIN would be more appropriate, especially in the power
state transition and BIST cases. An interesting possibility might be to
have the file actually block, although I'm not sure if the O_NONBLOCK
flag or polling for that matter can be supported through the
sysfs/driver-core API.
-Adam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- References:
- Re: [linux-pm] Bug in PCI core
- From: Alan Stern
- Re: [linux-pm] Bug in PCI core
- From: Alan Cox
- Re: [linux-pm] Bug in PCI core
- From: Arjan van de Ven
- Re: [linux-pm] Bug in PCI core
- Prev by Date: Re: 2.6.19-rc1-mm1 - locks when using "dd bs=1M" from card reader
- Next by Date: Re: [RFC]: Possible race condition on an SMP between proc_lookupfd and tasks on other cpus
- Previous by thread: Re: [linux-pm] Bug in PCI core
- Next by thread: Re: [linux-pm] Bug in PCI core
- Index(es):
Relevant Pages
|
Loading
