Re: Bug in PCI core
- From: Greg KH <greg@xxxxxxxxx>
- Date: Fri, 13 Oct 2006 22:34:48 -0700
On Wed, Oct 11, 2006 at 04:41:22PM -0400, Alan Stern wrote:
When a PCI device is suspended, its driver calls pci_save_state() so that
the config space can be restored when the device is resumed. Then the
driver calls pci_set_power_state().
However pci_set_power_state() calls pci_block_user_cfg_access(), and that
routine calls pci_save_state() again. This overwrites the saved state
with data in which memory, I/O, and bus master accesses are disabled. As
a result, when the device is resumed it doesn't work.
Obviously pci_block_user_cfg_access() needs to be fixed. I don't know the
right way to fix it; hopefully somebody else does.
Yeah, I'm just going to drop the patch from Matthew that added this.
Andrew also noted that it causes bad things to happen on his laptop.
Thanks for pointing it out.
I gotta get suspend working on a machine here so I can test these things
better...
thanks,
greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- References:
- Bug in PCI core
- From: Alan Stern
- Bug in PCI core
- Prev by Date: Re: [PATCH] [PCI] Prevent user config space access during power state transitions
- Next by Date: Re: [stable] [patch 06/67] Video: cx24123: fix PLL divisor setup
- Previous by thread: Re: [linux-pm] Bug in PCI core
- Next by thread: [PATCH 1/4] Char: mxser_new, correct intr handler proto
- Index(es):
Relevant Pages
|
