Re: [PATCH 08/18] V4L/DVB (4734): Tda826x: fix frontend selection for dvb_attach

Em Sáb, 2006-10-14 às 21:14 +0200, Adrian Bunk escreveu:
On Sat, Oct 14, 2006 at 02:57:10PM -0400, Michael Krufky wrote:
Adrian Bunk wrote:

Two separate problems, please do not confuse them.

My tda10086 and tda826x patches are correct -- there is no question of it.

The problem is that they don't fix the whole problem.
Yes. Trent made two patches using your suggestion of checking for
MODULE. I'll submit it to Linus probably tomorrow after some tests.

If you want to review, they are at:
http://linuxtv.org/hg/v4l-dvb?cmd=changeset;node=b8c06286cb3a;style=gitweb
http://linuxtv.org/hg/v4l-dvb?cmd=changeset;node=18a778dbf540;style=gitweb

To be honest and after looking deeper at it, I don't like this
CONFIG_DVB_FE_CUSTOMIZE approach at all since it adds that much
complexity for not much gain.
Yes, it adds some complexity. The gain, however, is to allow having
smaller kernel size on embedded systems and DVR using MythTV or Freevo.
There's a similar feature for V4L (Autoselect pertinent
encoders/decoders and other helper chips), that allows selecting just
the needed stuff.

I'd simply select all frontends unconditionally
Most users do this, including me :)

Cheers,
Mauro.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [PATCH 08/18] V4L/DVB (4734): Tda826x: fix frontend selection for dvb_attach
    ... please do not confuse them. ... My tda10086 and tda826x patches are correct -- there is no question of it. ... smaller kernel size on embedded systems and DVR using MythTV or Freevo. ... There had been need of rain for many days. ...
    (Linux-Kernel)
  • Re: [Lhms-devel] [PATCH 0/7] Fragmentation Avoidance V19
    ... >> awful lot of complexity to some of these code paths yourself ... ... > then the frag patches can't guarantee anything either. ... an excellent probability of success, that's as good as you're going to ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)
  • Re: Office Patch Error
    ... In the left hand window, click on the + sign in the box to expand the ... That's when you'll see a key that is called "Patches" (not to ... After you have installed Service Pack 2 (and be sure to disconnect from ... registry can confuse anybody), let me know and I'll try to walk you ...
    (microsoft.public.office.misc)
  • Re: [Lhms-devel] [PATCH 0/7] Fragmentation Avoidance V19
    ... The memory footprint of this ... >> approach is smaller than introducing new zones. ... The patches do ad a reasonable amount of complexity to the page allocator. ...
    (Linux-Kernel)
  • Re: [ 00/10] [Suspend2] Modules support.
    ... On Friday 03 February 2006 21:44, Pavel Machek wrote: ... patches he does not understand. ... and yet you're perfectly happy to add the complexity of sticking half ... showing such a deadlock clearly. ...
    (Linux-Kernel)