Re: [v4l-dvb-maintainer] [PATCH] V4L/DVB: potential leak in dvb-bt8xx

Em Dom, 2006-10-15 às 20:35 +0400, Manu Abraham escreveu:
Florin Malita wrote:
Trent Piepho wrote:
I believe that 'state' will be kfree'd by the dst_attach() function if there
is a failure. Not what you would expect, to have it allocated in the bt8xx
driver (why do is there??) and freed on error in a different function.


Hm, you're right - it is kfreed in dst_attach(). But we're still missing
the kmalloc result check...


This patch was applied a few days back

Yes.

It is at:
http://www.kernel.org/git/?p=linux/kernel/git/mchehab/v4l-dvb.git;a=commit;h=626ae83bb24927ca015503448f0199842ae2e8da

I've already asked Linus to pull it, together with other 17 fixes, to
Mainstream.

Manu
Cheers,
Mauro.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [v4l-dvb-maintainer] [PATCH] V4L/DVB: potential leak in dvb-bt8xx
    ... Florin Malita wrote: ... is a failure. ... to have it allocated in the bt8xx ... driver and freed on error in a different function. ...
    (Linux-Kernel)
  • Re: [v4l-dvb-maintainer] [PATCH] V4L/DVB: potential leak in dvb-bt8xx
    ... Mauro Carvalho Chehab wrote: ... is a failure. ... to have it allocated in the bt8xx ... driver and freed on error in a different function. ...
    (Linux-Kernel)
  • Re: [v4l-dvb-maintainer] [PATCH] V4L/DVB: potential leak in dvb-bt8xx
    ... Trent Piepho wrote: ... is a failure. ... to have it allocated in the bt8xx ... driver and freed on error in a different function. ...
    (Linux-Kernel)
  • Re: Max SAN time out
    ... It depends on if a hard error was raised by the IO driver or the OS, ... A Soft failure is more tolerable. ... If say a SAN Fiber Switch keeps the port up to the SQL Server, but the SAN drops totally on another port, and the switch does not return an error code, you then get into IO driver and OS defined timeouts. ... Soft failure followed by a hard failure. ...
    (microsoft.public.sqlserver.clustering)
  • Re: Max SAN time out
    ... A Soft failure is more tolerable. ... If a hard error comes up the driver stack to SQL Server, ... If say a SAN Fiber Switch keeps the port up to the SQL Server, ...
    (microsoft.public.sqlserver.clustering)