Re: [PATCH] Freeze bdevs when freezing processes.
- From: David Chinner <dgc@xxxxxxx>
- Date: Thu, 26 Oct 2006 17:30:22 +1000
On Wed, Oct 25, 2006 at 09:05:56PM +0200, Rafael J. Wysocki wrote:
On Wednesday, 25 October 2006 15:23, Nigel Cunningham wrote:
Well, my impression is that this is exactly what happens here: Something
in the XFS code causes metadata to be written to disk _after_ the atomic
snapshot.
That's why I asked if the dirty XFS metadata were flushed by a kernel thread.
When I first added bdev freezing it was because there was an XFS timer
doing writes.
Yes, I noticed you said that, but I'd like someone from the XFS team to either
confirm or deny it.
We have daemons running in the background that can definitely do stuff
after a sync. hmm - one does try_to_freeze() after a wakeup, the
other does:
if (unlikely(freezing(current))) {
set_bit(XBT_FORCE_SLEEP, &target->bt_flags);
refrigerator();
} else {
clear_bit(XBT_FORCE_SLEEP, &target->bt_flags);
}
before it goes to sleep. So that one (xfsbufd - metadata buffer flushing)
can definitely wake up after the sync and do work, and the other could if
the kernel thread freeze occurs after the sync.
Another good question at this point - exactly how should we be putting
these thread to to sleep? Are both these valid methods for freezing them?
And should we be freezing when we wake up instead of before we go to
sleep? i.e. what are teh rules we are supposed to be following?
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH] Freeze bdevs when freezing processes.
- From: Nigel Cunningham
- Re: [PATCH] Freeze bdevs when freezing processes.
- References:
- [PATCH] Freeze bdevs when freezing processes.
- From: Nigel Cunningham
- Re: [PATCH] Freeze bdevs when freezing processes.
- From: Rafael J. Wysocki
- Re: [PATCH] Freeze bdevs when freezing processes.
- From: Nigel Cunningham
- Re: [PATCH] Freeze bdevs when freezing processes.
- From: Rafael J. Wysocki
- [PATCH] Freeze bdevs when freezing processes.
- Prev by Date: Re: [PATCH] MMC: Poll card status after rescanning cards
- Next by Date: Re: [Cbe-oss-dev] [PATCH 12/16] cell: add temperature to SPU and CPU sysfs entries
- Previous by thread: Re: [PATCH] Freeze bdevs when freezing processes.
- Next by thread: Re: [PATCH] Freeze bdevs when freezing processes.
- Index(es):
Relevant Pages
|
