Re: [PATCH] Freeze bdevs when freezing processes.

Hi!

As you have them at the moment, the threads seem to be freezing fine.
The issue I've seen in the past related not to threads but to timer
based activity. Admittedly it was 2.6.14 when I last looked at it, but
there used to be a possibility for XFS to submit I/O from a timer when
the threads are frozen but the bdev isn't frozen. Has that changed?

I didn't think we've ever done that - periodic or delayed operations
are passed off to the kernel threads to execute. A stack trace
(if you still have it) would be really help here.

Hmmm - we have a couple of per-cpu work queues as well that are
used on I/O completion and that can, in some circumstances,
trigger new transactions. If we are only flush metadata, then
I don't think that any more I/o will be issued, but I could be
wrong (maze of twisty passages).

Well, I think this exactly is the problem, because worker_threads run with
PF_NOFREEZE set (as I've just said in another message).

Ok, so freezing the filesystem is the only way you can prevent
this as the workqueues are flushed as part of quiescing the filesystem.

Well, alternative is to teach XFS to sense that we are being frozen
and stop disk writes in such case.

OTOH freeze_bdevs is perhaps not that bad solution...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [PATCH] Freeze bdevs when freezing processes.
    ... The issue I've seen in the past related not to threads but to timer ... used on I/O completion and that can, in some circumstances, ... this as the workqueues are flushed as part of quiescing the filesystem. ... Now at last I know what the problem actually is and why we need the freezing ...
    (Linux-Kernel)
  • Re: [PATCH] Freeze bdevs when freezing processes.
    ... The issue I've seen in the past related not to threads but to timer ... A stack trace ... used on I/O completion and that can, in some circumstances, ... this as the workqueues are flushed as part of quiescing the filesystem. ...
    (Linux-Kernel)
  • Re: [PATCH] Freeze bdevs when freezing processes.
    ... The issue I've seen in the past related not to threads but to timer ... this as the workqueues are flushed as part of quiescing the filesystem. ... appended is a patch that implements the freezing of bdevs in a slightly ... s2disk/5564 is trying to acquire lock: ...
    (Linux-Kernel)
  • Re: Dynamic configure max_cstate
    ... fio is a disk I/O workload ... are we actually taking ACPI Cx exit latency into account, ... I also thought it's related to timer. ...
    (Linux-Kernel)
  • Re: LPT square wave
    ... timer or just plain delays? ... Printer port I/O is handled via the legacy ISA bus transaction ... My preference for things like this is to actually use DOS on an older ...
    (sci.electronics.design)
Loading