Re: + lkdtm-module_param-fixes.patch added to -mm tree

On Tue, 31 Oct 2006 00:37:59 -0800 akpm@xxxxxxxx wrote:

This patch is even cleaner:
http://lkml.org/lkml/2006/10/23/390

Did you drop it? never see/have it?


------------------------------------------------------
Subject: lkdtm: module_param fixes
From: Andrew Morton <akpm@xxxxxxxx>

A assume these permissions were a typo - Alexey's
compile-time-check-re-world-writeable-module-params.patch catches it.

Fix a typo in the help string too.

Cc: Alexey Dobriyan <adobriyan@xxxxxxxxx>
Cc: Ankita Garg <ankita@xxxxxxxxxx>
Cc: Vivek Goyal <vgoyal@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---

drivers/misc/lkdtm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff -puN drivers/misc/lkdtm.c~lkdtm-module_param-fixes drivers/misc/lkdtm.c
--- a/drivers/misc/lkdtm.c~lkdtm-module_param-fixes
+++ a/drivers/misc/lkdtm.c
@@ -116,14 +116,14 @@ static enum ctype cptype = NONE;
static int count = DEFAULT_COUNT;

module_param(recur_count, int, 0644);
-MODULE_PARM_DESC(recur_count, "Recurcion level for the stack overflow test,\
+MODULE_PARM_DESC(recur_count, "Recursion level for the stack overflow test,\
default is 10");
module_param(cpoint_name, charp, 0644);
MODULE_PARM_DESC(cpoint_name, "Crash Point, where kernel is to be crashed");
-module_param(cpoint_type, charp, 06444);
+module_param(cpoint_type, charp, 0644);
MODULE_PARM_DESC(cpoint_type, "Crash Point Type, action to be taken on\
hitting the crash point");
-module_param(cpoint_count, int, 06444);
+module_param(cpoint_count, int, 0644);
MODULE_PARM_DESC(cpoint_count, "Crash Point Count, number of times the \
crash point is to be hit to trigger action");

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • please pull from the trivial tree
    ... trivial documentation patch for platform.txt ... fix SCSI_SCAN_ASYNC help text ... Various typo fixes. ... Remove useless FIND_FIRST_BITmacro from cardbus.c. ...
    (Linux-Kernel)
  • [PATCH] time: fix typo that makes sync_cmos_clock erratic
    ... Fix a typo in ntp.c that has caused updating of the persistent clock when synced to NTP to behave erratically. ... When debugging a freeze that arises on my AMD64 machines when I run the ntpd service, I added a number of printk's to monitor the sync_cmos_clock procedure. ... I discovered that it was not syncing to cmos RTC every 11 minutes as documented, but instead would keep trying every second for hours at a time. ... The reason turned out to be a typo in sync_cmos_clock, where it attempts to ensure that update_persistent_clock is called very close to 500 msec. after a 1 second boundary. ...
    (Linux-Kernel)
  • [PATCH] time: fix typo that makes sync_cmos_clock erratic
    ... Fix a typo in ntp.c that has caused updating of the persistent ... When debugging a freeze that arises on my AMD64 machines when I run the ... RTC every 11 minutes as documented, but instead would keep trying every ... I rewrote the code to fix the typo and to be a little more clear about ...
    (Linux-Kernel)
  • [patch] hrtimers: add state tracking, fix
    ... but it has now for the second time in a row caused a system freeze as ... thanks for the report - this made me review the hrtimer state engine ... Could you try the fix ... because the typo means we'd ignore HRTIMER_STATE_PENDING state ...
    (Linux-Kernel)
  • Re: [PATCH] rio: typo in bitwise AND expression.
    ... Subject: [PATCH] rio: typo in bitwise AND expression. ... Obvious fix is to change! ... Please read the FAQ at http://www.tux.org/lkml/ ...
    (Linux-Kernel)