[PATCH] init_reap_node() initialization fix



It looks like there is a bug in init_reap_node() in slab.c that can
cause multiple oops's on certain ES7000 configurations. The variable
reap_node is defined per cpu, but only initialized on a single CPU.
This causes an oops in next_reap_node() when __get_cpu_var(reap_node)
returns the wrong value. Fix is below.


Signed-off-by: Dan Yeisley <dan.yeisley@xxxxxxxxxx>
---

diff -Naur linux-2.6.19-rc3-org/mm/slab.c linux-2.6.19-rc3-work/mm/slab.c
--- linux-2.6.19-rc3-org/mm/slab.c 2006-10-23 19:02:02.000000000 -0400
+++ linux-2.6.19-rc3-work/mm/slab.c 2006-10-30 11:45:28.000000000 -0500
@@ -883,7 +883,7 @@
if (node == MAX_NUMNODES)
node = first_node(node_online_map);

- __get_cpu_var(reap_node) = node;
+ per_cpu(reap_node,cpu) = node;
}

static void next_reap_node(void)




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • Re: [PATCH] init_reap_node() initialization fix
    ... cause multiple oops's on certain ES7000 configurations. ... reap_node is defined per cpu, but only initialized on a single CPU. ...
    (Linux-Kernel)
  • Server Crash (2.6.17-1.2157)- BUG: soft lockup detected on CPU#3!
    ... I just installed Fedora Core Kernel 2.6.17-1.2157_FC5smp and immediately got a "BUG: soft lockup detected on CPU#3!", I've never had this on any other kernel version before, but on my desk top PC and now this server with this specific kernel. ... isg-dev7 kernel: CPU: 3 ... kernel BUG at include/linux/list.h:185! ... MEM window: dd200000-dd3fffff ...
    (Fedora)
  • Re: Why choose Kerio instead of ZA?
    ... bug fixed: parallel resolving of many addresses caused crash of GUI ... I just checked and KPF2 has one process using neglegible CPU ... I did notice that KPF4 is constantly reading and writing to the network via ... I browsed the Web using Windows Explorer. ...
    (comp.security.firewalls)
  • FS: Various PC bits, Sckt A MB, Athlon XP-M, RAID card, Tagan PSU, 2.5" SATA HDDs
    ... rather than making multiple threads. ... with control over the CPU voltage and multiplier, ... This is high quality RAM that can deal with overclocking, ... I'll knock £10 off the price if you buy the RAM, motherboard and CPU ...
    (uk.adverts.computer)
  • Re: whats faster, initialize component, or form load?
    ... for every algorithm there is parallel version. ... Suppose you need to initialize 1 form - parallel might not do any good ... of the overhead of handling multiple threads. ... Furthermore, even when they do want to use the CPU, they are ...
    (microsoft.public.dotnet.languages.csharp)