Re: [PATCH 1/2] sunrpc: add missing spin_unlock
- From: Andrew Morton <akpm@xxxxxxxx>
- Date: Sun, 5 Nov 2006 11:45:33 -0800
On Sun, 05 Nov 2006 17:35:16 +0100
Peter Zijlstra <a.p.zijlstra@xxxxxxxxx> wrote:
On Sun, 2006-10-29 at 22:37 +0900, Akinobu Mita wrote:
auth_domain_put() forgot to unlock acquired spinlock.
Cc: Olaf Kirch <okir@xxxxxxxxxxxx>
Cc: Andy Adamson <andros@xxxxxxxxxxxxxx>
Cc: J. Bruce Fields <bfields@xxxxxxxxxxxxxx>
Cc: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx>
Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx>
Acked-by: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
I just found this too while trying to get .19-rc4-git up and running on
a machine here - took me a few hours.
It made my kernel decidedly unhappy :-(
Andrew, could you push this and:
http://lkml.org/lkml/2006/11/3/109
into .19 still? - those patches are needed to make todays git happy on
my machine.
OK.
Index: work-fault-inject/net/sunrpc/svcauth.c
===================================================================
--- work-fault-inject.orig/net/sunrpc/svcauth.c
+++ work-fault-inject/net/sunrpc/svcauth.c
@@ -126,6 +126,7 @@ void auth_domain_put(struct auth_domain
if (atomic_dec_and_lock(&dom->ref.refcount, &auth_domain_lock)) {
hlist_del(&dom->hash);
dom->flavour->domain_release(dom);
+ spin_unlock(&auth_domain_lock);
}
}
I wonder if this will fix http://bugzilla.kernel.org/show_bug.cgi?id=7457
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH 1/2] sunrpc: add missing spin_unlock
- From: Elimar Riesebieter
- Re: [PATCH 1/2] sunrpc: add missing spin_unlock
- From: Peter Zijlstra
- Re: [PATCH 1/2] sunrpc: add missing spin_unlock
- References:
- Re: [PATCH 1/2] sunrpc: add missing spin_unlock
- From: Peter Zijlstra
- Re: [PATCH 1/2] sunrpc: add missing spin_unlock
- Prev by Date: PATCH? hrtimer_wakeup: fix a theoretical race wrt rt_mutex_slowlock()
- Next by Date: Re: [Opps] Invalid opcode
- Previous by thread: Re: [PATCH 1/2] sunrpc: add missing spin_unlock
- Next by thread: Re: [PATCH 1/2] sunrpc: add missing spin_unlock
- Index(es):
Relevant Pages
|
|
