[PATCH][STABLE 2.6.18] dm snapshot: fix freeing pending exception



Fix oops when removing full snapshot
kernel bugzilla bug 7040

If a snapshot became invalid (full) while there is outstanding
pending_exception, pending_complete() forgets to remove
the corresponding exception from its exception table before freeing it.

Already fixed in 2.6.19.

Signed-off-by: Milan Broz <mbroz@xxxxxxxxxx>

Index: linux-2.6.18.5/drivers/md/dm-snap.c
===================================================================
--- linux-2.6.18.5.orig/drivers/md/dm-snap.c 2006-12-02 01:13:05.000000000 +0100
+++ linux-2.6.18.5/drivers/md/dm-snap.c 2006-12-04 17:55:28.000000000 +0100
@@ -691,6 +691,7 @@ static void pending_complete(struct pend

free_exception(e);

+ remove_exception(&pe->e);
error_snapshot_bios(pe);
goto out;
}


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • Versioned pointers: a new method of representing snapshots
    ... A snapshot of a disk volume may be represented as a list of exceptions ... exception is present, the data resides on the origin volume. ... size chunk sharing bitmap, as is the existing practice in ddsnap. ... the geometry of the version tree changes and exception lists are ...
    (Linux-Kernel)
  • Re: Which process is locking a file ?
    ... | exception while trying to access a file. ... We are trying ways to find which other process is holding ... | not have a monitoring mode. ... open is by inspecting each process handle table (by taking a snapshot like ...
    (microsoft.public.dotnet.languages.csharp)
  • Re: Vista Media Center not starting
    ... snapshot, another download gets you the Media Center-specific snapshot). ... (Exception from HRESULT: 0x8007007E) ...
    (microsoft.public.windows.mediacenter)
  • [patch 12/24] dm snapshot: fix freeing pending exception
    ... kernel bugzilla bug 7040 ... If a snapshot became invalid while there is outstanding ... the corresponding exception from its exception table before freeing it. ...
    (Linux-Kernel)
  • [PATCH 11/25] dm snapshot: fix freeing pending exception
    ... If a snapshot became invalid while there are outstanding pending_exceptions, ... corresponding exception from its exception table before freeing it. ... goto out; ...
    (Linux-Kernel)