Re: [PATCH 0/3] New firewire stack

(Adding Cc: linux1394-devel)

Ben Collins wrote at linux-kernel:
On Tue, 2006-12-05 at 18:21 -0500, Kristian Høgsberg wrote:
Alexey Dobriyan wrote:
On Tue, Dec 05, 2006 at 12:22:29AM -0500, Kristian Høgsberg wrote:
I'm announcing an alternative firewire stack that I've been working on
the last few weeks.
Is mainline firewire so hopeless, that you've decided to rewrite it? Could
you show some ugly places in it?
Yes. I'm not doing this lightheartedly. It's a lot of work and it will
introduce regressions and instability for a little while.

My main point about ohci1394 (the old stacks PCI driver) is, that if you
really want to fix the issues with this driver, you have to shuffle the code
around so much that you'll introduce as many regressions as a clean rewrite.
The big problems in the ohci1394 drivers is the irq_handler, bus reset
handling and config rom handling. These are some of the strong points of
fw-ohci.c:

My main concern is that when I picked up ieee1394 maint myself, it was
because it was not big-endian or 64-bit friendly.

I would like to see new development efforts take cleanliness WRT host
byte order and 64bit architectures into account from the ground up. (I
understand though why Kristian made the announcement in this early
phase, and I agree with him that this kind of development has to go into
the open early.)

I spent the better
part of 3 months getting this right on PPC and UltraSPARC. Not because
it's hard to fix these issues, but because the hardware is not well
defined for a lot of these cases (I know you've seen the ohci1394 code
to handle endianness).

So while I can understand that ieee1394 doesn't have much man power
right now, and that there are some hard to find bugs in the current
tree, I can't see how starting from scratch alleviates this.

The tree is years old, and a lot of work has been put into it (lots of
my work, I'll admit I'm being a little protective). I'm not sure that
"replacing" it is wise, or even needed. Fork it, clean it up, but
rewriting just doesn't make sense.

Granted, this is your time, and you can spend it how you want, I just
don't want to see the ieee1394 stack take a step backwards in the hopes
that it will be better a year down the road.

No matter in which way we will put Kristian's work to use, regressions
must not happen --- beyond the measure that unintentionally happens when
bugs get fixed. Mainline's FireWire stack lost a lot of trust at
end-users and application developers because of periods of sometimes
very visible regressions.
--
Stefan Richter
-=====-=-==- ==-- --==-
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Relevant Pages

  • Re: [PATCH 0/3] New firewire stack
    ... My main point about ohci1394 (the old stacks PCI driver) is, ... around so much that you'll introduce as many regressions as a clean rewrite. ... handling and config rom handling. ... I would like to see new development efforts take cleanliness WRT host ...
    (Linux-Kernel)
  • Re: [mmc] alternative TI FM MMC/SD driver for 2.6.21-rc7
    ... I have found it easier to rewrite the driver, than to fix. ... Before you get your hopes up, this development model is not one that will get ...
    (Linux-Kernel)
  • Re: [PATCH 1/1] mtd maps - Blackfin Async Flash Maps (try #4): Handle the case where flash memor
    ... drop SSYNCwhen reading from the flash and rewrite ... Remove useless SSYNC() as Will said ... All board-specific configuration goes in your board resources file. ... If dwmw2 doesn't mind adding another mapping driver, ...
    (Linux-Kernel)
  • Re: [PATCH 0/3] New firewire stack
    ... My main point about ohci1394 (the old stacks PCI driver) is, ... around so much that you'll introduce as many regressions as a clean rewrite. ... handling and config rom handling. ... tree, I can't see how starting from scratch alleviates this. ...
    (Linux-Kernel)
  • Re: [PATCH 0/3] New firewire stack
    ... Is mainline firewire so hopeless, that you've decided to rewrite it? ... Please read the FAQ at http://www.tux.org/lkml/ ...
    (Linux-Kernel)