[patch 15/32] softmac: fix unbalanced mutex_lock/unlock in ieee80211softmac_wx_set_mlme



-stable review patch. If anyone has any objections, please let us know.
------------------

From: Maxime Austruy <maxime@xxxxxxxxxxxxx>

Routine ieee80211softmac_wx_set_mlme has one return that fails
to release a mutex acquired at entry.

Signed-off-by: Maxime Austruy <maxime@xxxxxxxxxxxxx>
Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
Signed-off-by: Chris Wright <chrisw@xxxxxxxxxxxx>
---

John and Chris,

This error was introduced in the 2.6.19-rxX series and must be applied
to 2.6.19-stable and wireless-2.6.

Larry

net/ieee80211/softmac/ieee80211softmac_wx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

--- linux-2.6.19.orig/net/ieee80211/softmac/ieee80211softmac_wx.c
+++ linux-2.6.19/net/ieee80211/softmac/ieee80211softmac_wx.c
@@ -495,7 +495,8 @@ ieee80211softmac_wx_set_mlme(struct net_
printk(KERN_DEBUG PFX "wx_set_mlme: we should know the net here...\n");
goto out;
}
- return ieee80211softmac_deauth_req(mac, net, reason);
+ err = ieee80211softmac_deauth_req(mac, net, reason);
+ goto out;
case IW_MLME_DISASSOC:
ieee80211softmac_send_disassoc_req(mac, reason);
mac->associnfo.associated = 0;

--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • Re: Passing txtBox to Sub
    ... my msgbox popups are only from the OK button routine. ... highlighting the bad entry until it is ... > be included in the validation, and keeps the whole thing centralized. ...
    (comp.lang.basic.visual.misc)
  • SSI experience
    ... in either LPA or the LNKLST [while debugging, ... requires LOAD-TO-GLOBAL option on the SSVTI entry which causes the routine ... If during CLOSE you'd like to reuse the working storage acquired by OPEN, ... various entry points, so I am also preserving its pointer ...
    (bit.listserv.ibm-main)
  • Re: memory error
    ... See if it fails. ... It's possible the code is failing on in the WriteLog routine. ... checkTextBoxes routine as Result is declared as a local variable, ... I have a very small dll that pops up a data ...
    (microsoft.public.vb.general.discussion)
  • Re: .Net (C#) Service Fails To Start
    ... > I have even placed debug code in the mainroutine -- to produce Event ... and if it fails no output whatsoever is produced. ... One of the things that mostly fail is the creation of a logon session ... check your eventlog for Logon failures. ...
    (microsoft.public.dotnet.languages.csharp)
  • Re: Is it possible to access register contents in a PL/I program?
    ... I think that's what the F compiler did, but according to the program listing shown in the Optimizing Compiler programmer's Guide, SC33-0006-4 the code at an entry point starts off as follows: ... Looking at this more carefully, I see that the code goes on to use the value at offset 76 in the caller's dsa as the proposed address of its own dsa; it adds to this the size of its dsa and compares the result to the value at 12to check for sufficient space. ... The upshot is that a non PL/I routine cannot blithely call a PL/I routine, so the code I gave will only work if the calling routine knows it is calling a PL/I routine and has allocated its dsa on the PL/I runtime stack. ...
    (comp.lang.pl1)