Re: [PATCH] connector: Some fixes for ia64 unaligned access errors
- From: Erik Jacobson <erikj@xxxxxxx>
- Date: Tue, 12 Dec 2006 20:31:32 -0600
But it's rather a lot of churn for such a thing. Did you consider simply using
put_unaligned() against the specific offending field(s)?
Hi. This was not considered.
I wanted to give you some quick feedback, so I tried your suggestion in the
fork path. It seemed to fix the problem as well.
put_unaligned(timespec_to_ns(&ts), (__u64 *) &ev->timestamp_ns);
Is what I tried.
I'm on vacation tomorrow but on Thursday, if you like, I can whip up
a patch that does this and test it more thoroughly. Is this the
direction you prefer? What I did just now was really quick and dirty
to see if it has a shot or not but it looks like put_unaligned will
fix it too.
--
Erik Jacobson - Linux System Software - SGI - Eagan, Minnesota
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH] connector: Some fixes for ia64 unaligned access errors
- From: Andrew Morton
- Re: [PATCH] connector: Some fixes for ia64 unaligned access errors
- References:
- [PATCH] connector: Some fixes for ia64 unaligned access errors
- From: Erik Jacobson
- Re: [PATCH] connector: Some fixes for ia64 unaligned access errors
- From: Matt Helsley
- Re: [PATCH] connector: Some fixes for ia64 unaligned access errors
- From: Erik Jacobson
- Re: [PATCH] connector: Some fixes for ia64 unaligned access errors
- From: Andrew Morton
- [PATCH] connector: Some fixes for ia64 unaligned access errors
- Prev by Date: RE: [PATCH] incorrect error handling inside generic_file_direct_write
- Next by Date: [PATCH] Alpha increase PERCPU_ENOUGH_ROOM
- Previous by thread: Re: [PATCH] connector: Some fixes for ia64 unaligned access errors
- Next by thread: Re: [PATCH] connector: Some fixes for ia64 unaligned access errors
- Index(es):
Relevant Pages
|
