[KORG] re: [PATCH] cfq-iosched: tighten allow merge criteria - error in final return value ?
- From: DAVID HORNER <dhorner@xxxxxxxxxx>
- Date: Fri, 29 Dec 2006 21:15:07 -0800 (PST)
I noticed a probable error in commit 719d34027e1a186e46a3952e8a24bf91ecc33837
....
- if (cfqq != RQ_CFQQ(rq))
- return 0;
+
+ if (cfqq == RQ_CFQQ(rq))
+ return 1;
return 1;
}
Either the final return value should be 0 (zero) or
the if statement is redundant.
(I lack the skill to make a timely patch,hope this helps)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Prev by Date: Re: [PATCH] Print sysrq-m messages with KERN_INFO priority
- Next by Date: Re: [BUG 2.6.20-rc2] atkbd.c: Spurious ACK
- Previous by thread: [PATCH] Print sysrq-m messages with KERN_INFO priority
- Next by thread: Re: make headers_install headers problem on sparc64
- Index(es):