Re: [S390] cio: fix stsch_reset.



In-Reply-To: <20061228103925.GB6270@skybase>

On Thu, 28 Dec 2006 11:39:25 +0100, Martin Schwidefsky wrote:

@@ -881,10 +880,18 @@ static void cio_reset_pgm_check_handler(
static int stsch_reset(struct subchannel_id schid, volatile struct schib *addr)
{
int rc;
+ register struct subchannel_id reg1 asm ("1") = schid;

pgm_check_occured = 0;
s390_reset_pgm_handler = cio_reset_pgm_check_handler;
- rc = stsch(schid, addr);
+
+ asm volatile(
+ " stsch 0(%2)\n"
+ " ipm %0\n"
+ " srl %0,28"
+ : "=d" (rc)
+ : "d" (reg1), "a" (addr), "m" (*addr) : "memory", "cc");
+
s390_reset_pgm_handler = NULL;
if (pgm_check_occured)
return -EIO;


Can't you just put a barrier() before the stsch() call?

--
MBTI: IXTP

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Relevant Pages

  • Re: [S390] cio: fix stsch_reset.
    ... static int stsch_reset(struct subchannel_id schid, volatile struct schib *addr) ...
    (Linux-Kernel)
  • Re: [S390] cio: fix stsch_reset.
    ... static int stsch_reset(struct subchannel_id schid, volatile struct schib *addr) ... Can't you just put a barrierbefore the stsch() call? ...
    (Linux-Kernel)
  • Re: [PATCH 1/5] freepgt: free_pgtables use vma list
    ... +static void unmap_im_area(unsigned long addr, ... -static void map_io_page(unsigned long ea, unsigned long pa, int flags) ... static int iounmap_subset_regions ...
    (Linux-Kernel)
  • Re: 2.6.10-mm3: swsusp: out of memory on resume (was: Re: Ho ho ho - Linux v2.6.10)
    ... Try Lukas's patch, ... +static int __init does_collide_order(unsigned long addr, ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ ...
    (Linux-Kernel)
  • [PATCH] Fix 2.6.7 Alpha compilation
    ... +find_next_bit(const void * addr, unsigned long size, unsigned long offset) ... send the line "unsubscribe linux-kernel" in ...
    (Linux-Kernel)